Mercurial > sdl-ios-xcode
view src/SDL_fatal.c @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | f7b03b6838cb |
children | b530ef003506 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* General fatal signal handling code for SDL */ #ifdef HAVE_SIGNAL_H #include <signal.h> #include "SDL.h" #include "SDL_fatal.h" /* This installs some signal handlers for the more common fatal signals, so that if the programmer is lazy, the app doesn't die so horribly if the program crashes. */ static void SDL_Parachute(int sig) { signal(sig, SIG_DFL); SDL_Quit(); raise(sig); } static const int SDL_fatal_signals[] = { SIGSEGV, #ifdef SIGBUS SIGBUS, #endif #ifdef SIGFPE SIGFPE, #endif #ifdef SIGQUIT SIGQUIT, #endif 0 }; void SDL_InstallParachute(void) { /* Set a handler for any fatal signal not already handled */ int i; #ifdef HAVE_SIGACTION struct sigaction action; for (i = 0; SDL_fatal_signals[i]; ++i) { sigaction(SDL_fatal_signals[i], NULL, &action); if (action.sa_handler == SIG_DFL) { action.sa_handler = SDL_Parachute; sigaction(SDL_fatal_signals[i], &action, NULL); } } #ifdef SIGALRM /* Set SIGALRM to be ignored -- necessary on Solaris */ sigaction(SIGALRM, NULL, &action); if (action.sa_handler == SIG_DFL) { action.sa_handler = SIG_IGN; sigaction(SIGALRM, &action, NULL); } #endif #else void (*ohandler) (int); for (i = 0; SDL_fatal_signals[i]; ++i) { ohandler = signal(SDL_fatal_signals[i], SDL_Parachute); if (ohandler != SIG_DFL) { signal(SDL_fatal_signals[i], ohandler); } } #endif /* HAVE_SIGACTION */ return; } void SDL_UninstallParachute(void) { /* Remove a handler for any fatal signal handled */ int i; #ifdef HAVE_SIGACTION struct sigaction action; for (i = 0; SDL_fatal_signals[i]; ++i) { sigaction(SDL_fatal_signals[i], NULL, &action); if (action.sa_handler == SDL_Parachute) { action.sa_handler = SIG_DFL; sigaction(SDL_fatal_signals[i], &action, NULL); } } #else void (*ohandler) (int); for (i = 0; SDL_fatal_signals[i]; ++i) { ohandler = signal(SDL_fatal_signals[i], SIG_DFL); if (ohandler != SDL_Parachute) { signal(SDL_fatal_signals[i], ohandler); } } #endif /* HAVE_SIGACTION */ } #else /* No signals on this platform, nothing to do.. */ void SDL_InstallParachute(void) { return; } void SDL_UninstallParachute(void) { return; } #endif /* HAVE_SIGNAL_H */ /* vi: set ts=4 sw=4 expandtab: */