Mercurial > sdl-ios-xcode
view VisualCE/SDL.vcw @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | d63e9f5944ae |
children |
line wrap: on
line source
Microsoft eMbedded Visual Tools Workspace File, Format Version 3.00 # WARNING: DO NOT EDIT OR DELETE THIS WORKSPACE FILE! ############################################################################### Project: "loopwave"=.\loopwave\loopwave.vcp - Package Owner=<4> Package=<5> {{{ }}} Package=<4> {{{ Begin Project Dependency Project_Dep_Name SDL End Project Dependency Begin Project Dependency Project_Dep_Name SDLmain End Project Dependency }}} ############################################################################### Project: "SDL"=.\SDL\SDL.VCP - Package Owner=<4> Package=<5> {{{ }}} Package=<4> {{{ }}} ############################################################################### Project: "SDLmain"=.\SDLmain\SDLmain.vcp - Package Owner=<4> Package=<5> {{{ }}} Package=<4> {{{ Begin Project Dependency Project_Dep_Name SDL End Project Dependency }}} ############################################################################### Project: "testtimer"=.\testtimer\testtimer.vcp - Package Owner=<4> Package=<5> {{{ }}} Package=<4> {{{ Begin Project Dependency Project_Dep_Name SDL End Project Dependency Begin Project Dependency Project_Dep_Name SDLmain End Project Dependency }}} ############################################################################### Project: "testalpha"=.\testalpha\testalpha.vcp - Package Owner=<4> Package=<5> {{{ }}} Package=<4> {{{ Begin Project Dependency Project_Dep_Name SDL End Project Dependency Begin Project Dependency Project_Dep_Name SDLmain End Project Dependency }}} ############################################################################### Project: "testwin"=.\testwin\testwin.vcp - Package Owner=<4> Package=<5> {{{ }}} Package=<4> {{{ Begin Project Dependency Project_Dep_Name SDL End Project Dependency Begin Project Dependency Project_Dep_Name SDLmain End Project Dependency }}} ############################################################################### Global: Package=<5> {{{ }}} Package=<3> {{{ }}} ###############################################################################