Mercurial > sdl-ios-xcode
view TODO @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Mon, 12 Jul 2010 22:08:50 -0700 |
| parents | 6604099437ac |
| children | 0bfda420c936 |
line wrap: on
line source
1.3 release checklist: * http://wiki.libsdl.org/moin.cgi/Roadmap * See why windows are being rearranged. Is the shield window not up? * Make sure you can create and show a fullscreen window in one step * Figure out how to handle OpenGL context lost on Mac OS X (does it happen?) * Write automated test case for multi-draw APIs * Make sure you can build SDL without the renderer to slim it down a bunch * Implement assertion code on iPhone * Add __WINDOWS__ in addition to __WIN32__ * Check 1.2 revisions: 3554 - Need to resolve semantics for locking keys on different platforms 4874 - Do we want screen rotation? At what level? 4974 - Windows file code needs to convert UTF-8 to Unicode, but we don't need to tap dance for Windows 95/98 4484, 4485 - Verify that SDL's Windows keyboard handling works correctly 4865 - See if this is still needed (mouse coordinate clamping) 4866 - See if this is still needed (blocking window repositioning)