Mercurial > sdl-ios-xcode
view src/video/picogui/SDL_pgevents.c @ 1544:ab1e4c41ab71
Fixed bug #33
Mike Frysinger wrote:
> with libsdl-1.2.9, some games (like bomberclone) started
> segfaulting in Gentoo
[...snip...]
> the last change in the last hunk:
[...snip...]
> if i change the statement to read:
> (table[which].blit_features & GetBlitFeatures()) == GetBlitFeatures()
> bomberclone no longer segfaults on my box
Alex Volkov wrote:
> The test "(table[which].blit_features & GetBlitFeatures()) ==
> table[which].blit_features)" is correct, and the previous
> "(table[which].cpu_mmx == SDL_HasMMX())" was actually broken.
I think there is potentially a slightly different cause of the above problem.
During the introduction of the Altivec code, the blit_table struct field
'alpha' got changed from a straightforward enum to a bitmask, which makes
perfect sense by itself. However, now the table driven blitter selection code
in SDL_CalculateBlitN() can choose the wrong blitters when searching for a
NO_ALPHA blitter because of the following code:
int a_need = 0;
...
(a_need & table[which].alpha) == a_need &&
When searching through the normal_blit_2[] table, a SET_ALPHA blitter (like
Blit_RGB565_ARGB8888) can now be selected instead of a NO_ALPHA one, causing
alpha channel bits to appear in a non-alpha destination surface. I suppose this
could theoretically be an indirect cause of the segfault mentioned above.
I *think* this can be fixed by changing to
int a_need = NO_ALPHA;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 15 Mar 2006 15:47:49 +0000 |
parents | d910939febfa |
children | 782fd950bd46 c121d94672cb a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org Micah Dowty micahjd@users.sourceforge.net */ #include "SDL_config.h" #include "SDL.h" #include "../../events/SDL_sysevents.h" #include "../../events/SDL_events_c.h" #include "SDL_pgvideo.h" #include "SDL_pgevents_c.h" int PG_HandleClose(struct pgEvent *evt) { SDL_PrivateQuit(); return 1; /* Intercept the event's normal quit handling */ } int PG_HandleResize(struct pgEvent *evt) { SDL_PrivateResize(evt->e.size.w, evt->e.size.h); return 0; } int PG_HandleKey(struct pgEvent *evt) { SDL_keysym sym; SDL_memset(&sym,0,sizeof(sym)); sym.sym = evt->e.kbd.key; sym.mod = evt->e.kbd.mods; SDL_PrivateKeyboard(evt->type == PG_WE_KBD_KEYDOWN, &sym); return 0; } int PG_HandleChar(struct pgEvent *evt) { SDL_keysym sym; SDL_memset(&sym,0,sizeof(sym)); sym.unicode = evt->e.kbd.key; sym.mod = evt->e.kbd.mods; SDL_PrivateKeyboard(evt->type == PG_WE_KBD_KEYDOWN, &sym); return 0; } int PG_HandleMouseButton(struct pgEvent *evt) { /* We need to focus the canvas when it's clicked */ if (evt->extra) { SDL_VideoDevice *this = (SDL_VideoDevice *) evt->extra; pgFocus(this->hidden->wCanvas); } SDL_PrivateMouseButton(evt->type == PG_WE_PNTR_DOWN, evt->e.pntr.chbtn, evt->e.pntr.x, evt->e.pntr.y); return 0; } int PG_HandleMouseMotion(struct pgEvent *evt) { SDL_PrivateMouseMotion(evt->e.pntr.btn,0,evt->e.pntr.x, evt->e.pntr.y); return 0; } void PG_PumpEvents(_THIS) { /* Process all pending events */ pgEventPoll(); } void PG_InitOSKeymap(_THIS) { /* We need no keymap */ } void PG_InitEvents(_THIS) { /* Turn on all the mouse and keyboard triggers for our canvas, normally less important * events like mouse movement are ignored to save bandwidth. */ pgSetWidget(this->hidden->wCanvas, PG_WP_TRIGGERMASK, pgGetWidget(this->hidden->wCanvas, PG_WP_TRIGGERMASK) | PG_TRIGGER_UP | PG_TRIGGER_DOWN | PG_TRIGGER_MOVE | PG_TRIGGER_KEYUP | PG_TRIGGER_KEYDOWN | PG_TRIGGER_CHAR,0); /* Start our canvas out focused, so we get keyboard input */ pgFocus(this->hidden->wCanvas); /* Set up bindings for all the above event handlers */ pgBind(this->hidden->wApp, PG_WE_CLOSE, &PG_HandleClose, NULL); pgBind(this->hidden->wCanvas, PG_WE_BUILD, &PG_HandleResize, NULL); pgBind(this->hidden->wCanvas, PG_WE_KBD_CHAR, &PG_HandleChar, NULL); pgBind(this->hidden->wCanvas, PG_WE_KBD_KEYUP, &PG_HandleKey, NULL); pgBind(this->hidden->wCanvas, PG_WE_KBD_KEYDOWN, &PG_HandleKey, NULL); pgBind(this->hidden->wCanvas, PG_WE_PNTR_MOVE, &PG_HandleMouseMotion, NULL); pgBind(this->hidden->wCanvas, PG_WE_PNTR_UP, &PG_HandleMouseButton, NULL); pgBind(this->hidden->wCanvas, PG_WE_PNTR_DOWN, &PG_HandleMouseButton, this); } /* end of SDL_pgevents.c ... */