Mercurial > sdl-ios-xcode
view src/main/qtopia/SDL_qtopia_main.cc @ 1544:ab1e4c41ab71
Fixed bug #33
Mike Frysinger wrote:
> with libsdl-1.2.9, some games (like bomberclone) started
> segfaulting in Gentoo
[...snip...]
> the last change in the last hunk:
[...snip...]
> if i change the statement to read:
> (table[which].blit_features & GetBlitFeatures()) == GetBlitFeatures()
> bomberclone no longer segfaults on my box
Alex Volkov wrote:
> The test "(table[which].blit_features & GetBlitFeatures()) ==
> table[which].blit_features)" is correct, and the previous
> "(table[which].cpu_mmx == SDL_HasMMX())" was actually broken.
I think there is potentially a slightly different cause of the above problem.
During the introduction of the Altivec code, the blit_table struct field
'alpha' got changed from a straightforward enum to a bitmask, which makes
perfect sense by itself. However, now the table driven blitter selection code
in SDL_CalculateBlitN() can choose the wrong blitters when searching for a
NO_ALPHA blitter because of the following code:
int a_need = 0;
...
(a_need & table[which].alpha) == a_need &&
When searching through the normal_blit_2[] table, a SET_ALPHA blitter (like
Blit_RGB565_ARGB8888) can now be selected instead of a NO_ALPHA one, causing
alpha channel bits to appear in a non-alpha destination surface. I suppose this
could theoretically be an indirect cause of the segfault mentioned above.
I *think* this can be fixed by changing to
int a_need = NO_ALPHA;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 15 Mar 2006 15:47:49 +0000 |
parents | 623b453a3219 |
children | 782fd950bd46 c121d94672cb |
line wrap: on
line source
/* Include the SDL main definition header */ #include "SDL_main.h" #include <stdlib.h> #include <unistd.h> #ifdef main #undef main #endif #ifdef QWS #include <qpe/qpeapplication.h> #include <qapplication.h> #include <qpe/qpeapplication.h> #include <stdlib.h> // Workaround for OPIE to remove taskbar icon. Also fixes // some issues in Qtopia where there are left-over qcop files in /tmp/. // I'm guessing this will also clean up the taskbar in the Sharp version // of Qtopia. static inline void cleanupQCop() { QString appname(qApp->argv()[0]); int slash = appname.findRev("/"); if(slash != -1) { appname = appname.mid(slash+1); } QString cmd = QPEApplication::qpeDir() + "bin/qcop QPE/System 'closing(QString)' '"+appname+"'"; system(cmd.latin1()); cmd = "/tmp/qcop-msg-"+appname; unlink(cmd.latin1()); } static QPEApplication *app; #endif extern int SDL_main(int argc, char *argv[]); int main(int argc, char *argv[]) { #ifdef QWS // This initializes the Qtopia application. It needs to be done here // because it parses command line options. app = new QPEApplication(argc, argv); QWidget dummy; app->showMainWidget(&dummy); atexit(cleanupQCop); #endif // Exit here because if return is used, the application // doesn't seem to quit correctly. exit(SDL_main(argc, argv)); }