Mercurial > sdl-ios-xcode
view src/loadso/macos/SDL_sysloadso.c @ 1544:ab1e4c41ab71
Fixed bug #33
Mike Frysinger wrote:
> with libsdl-1.2.9, some games (like bomberclone) started
> segfaulting in Gentoo
[...snip...]
> the last change in the last hunk:
[...snip...]
> if i change the statement to read:
> (table[which].blit_features & GetBlitFeatures()) == GetBlitFeatures()
> bomberclone no longer segfaults on my box
Alex Volkov wrote:
> The test "(table[which].blit_features & GetBlitFeatures()) ==
> table[which].blit_features)" is correct, and the previous
> "(table[which].cpu_mmx == SDL_HasMMX())" was actually broken.
I think there is potentially a slightly different cause of the above problem.
During the introduction of the Altivec code, the blit_table struct field
'alpha' got changed from a straightforward enum to a bitmask, which makes
perfect sense by itself. However, now the table driven blitter selection code
in SDL_CalculateBlitN() can choose the wrong blitters when searching for a
NO_ALPHA blitter because of the following code:
int a_need = 0;
...
(a_need & table[which].alpha) == a_need &&
When searching through the normal_blit_2[] table, a SET_ALPHA blitter (like
Blit_RGB565_ARGB8888) can now be selected instead of a NO_ALPHA one, causing
alpha channel bits to appear in a non-alpha destination surface. I suppose this
could theoretically be an indirect cause of the segfault mentioned above.
I *think* this can be fixed by changing to
int a_need = NO_ALPHA;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 15 Mar 2006 15:47:49 +0000 |
parents | d910939febfa |
children | 92947e3a18db |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ /* System dependent library loading routines */ #include <stdio.h> #include <string.h> #define OLDP2C 1 #include <Strings.h> #include <CodeFragments.h> #include <Errors.h> #include "SDL_loadso.h" void *SDL_LoadObject(const char *sofile) { void *handle = NULL; const char *loaderror = NULL; CFragConnectionID library_id; Ptr mainAddr; Str255 errName; OSErr error; char psofile[512]; SDL_strlcpy(psofile, sofile, SDL_arraysize(psofile)); error = GetSharedLibrary(C2PStr(psofile), kCompiledCFragArch, kLoadCFrag, &library_id, &mainAddr, errName); switch (error) { case noErr: loaderror = NULL; break; case cfragNoLibraryErr: loaderror = "Library not found"; break; case cfragUnresolvedErr: loaderror = "Unabled to resolve symbols"; break; case cfragNoPrivateMemErr: case cfragNoClientMemErr: loaderror = "Out of memory"; break; default: loaderror = "Unknown Code Fragment Manager error"; break; } if ( loaderror == NULL ) { handle = (void *)(library_id); } else { SDL_SetError("Failed loading %s: %s", sofile, loaderror); } return(handle); } void *SDL_LoadFunction(void *handle, const char *name) { void *symbol = NULL; const char *loaderror = NULL; CFragSymbolClass class; CFragConnectionID library_id = (CFragConnectionID)handle; char pname[512]; SDL_strlcpy(pname, name, SDL_arraysize(pname)); if ( FindSymbol(library_id, C2PStr(pname), (char **)&symbol, &class) != noErr ) { loaderror = "Symbol not found"; } if ( symbol == NULL ) { SDL_SetError("Failed loading %s: %s", name, loaderror); } return(symbol); } void SDL_UnloadObject(void *handle) { CFragConnectionID library_id; if ( handle != NULL ) { library_id = (CFragConnectionID)handle; CloseConnection(&library_id); } }