Mercurial > sdl-ios-xcode
view src/cdrom/macosx/CDPlayer.h @ 1544:ab1e4c41ab71
Fixed bug #33
Mike Frysinger wrote:
> with libsdl-1.2.9, some games (like bomberclone) started
> segfaulting in Gentoo
[...snip...]
> the last change in the last hunk:
[...snip...]
> if i change the statement to read:
> (table[which].blit_features & GetBlitFeatures()) == GetBlitFeatures()
> bomberclone no longer segfaults on my box
Alex Volkov wrote:
> The test "(table[which].blit_features & GetBlitFeatures()) ==
> table[which].blit_features)" is correct, and the previous
> "(table[which].cpu_mmx == SDL_HasMMX())" was actually broken.
I think there is potentially a slightly different cause of the above problem.
During the introduction of the Altivec code, the blit_table struct field
'alpha' got changed from a straightforward enum to a bitmask, which makes
perfect sense by itself. However, now the table driven blitter selection code
in SDL_CalculateBlitN() can choose the wrong blitters when searching for a
NO_ALPHA blitter because of the following code:
int a_need = 0;
...
(a_need & table[which].alpha) == a_need &&
When searching through the normal_blit_2[] table, a SET_ALPHA blitter (like
Blit_RGB565_ARGB8888) can now be selected instead of a NO_ALPHA one, causing
alpha channel bits to appear in a non-alpha destination surface. I suppose this
could theoretically be an indirect cause of the segfault mentioned above.
I *think* this can be fixed by changing to
int a_need = NO_ALPHA;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 15 Mar 2006 15:47:49 +0000 |
parents | dc6b59e925a2 |
children | 782fd950bd46 c121d94672cb a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef __CDPlayer__H__ #define __CDPlayer__H__ 1 #include <string.h> #include <Carbon/Carbon.h> #include <CoreFoundation/CoreFoundation.h> #include <AudioUnit/AudioUnit.h> #include "SDL.h" #include "SDL_thread.h" #include "SDL_mutex.h" #ifdef __cplusplus extern "C" { #endif typedef void (*CDPlayerCompletionProc)(SDL_CD *cdrom) ; void Lock (); void Unlock(); int LoadFile (const FSRef *ref, int startFrame, int endFrame); /* pass -1 to do nothing */ int ReleaseFile (); int PlayFile (); int PauseFile (); void SetCompletionProc (CDPlayerCompletionProc proc, SDL_CD *cdrom); int ReadTOCData (FSVolumeRefNum theVolume, SDL_CD *theCD); int ListTrackFiles (FSVolumeRefNum theVolume, FSRef *trackFiles, int numTracks); int DetectAudioCDVolumes (FSVolumeRefNum *volumes, int numVolumes); int GetCurrentFrame (); #ifdef __cplusplus }; #endif #endif /* __CD_Player__H__ */