Mercurial > sdl-ios-xcode
view SDL.spec.in @ 1544:ab1e4c41ab71
Fixed bug #33
Mike Frysinger wrote:
> with libsdl-1.2.9, some games (like bomberclone) started
> segfaulting in Gentoo
[...snip...]
> the last change in the last hunk:
[...snip...]
> if i change the statement to read:
> (table[which].blit_features & GetBlitFeatures()) == GetBlitFeatures()
> bomberclone no longer segfaults on my box
Alex Volkov wrote:
> The test "(table[which].blit_features & GetBlitFeatures()) ==
> table[which].blit_features)" is correct, and the previous
> "(table[which].cpu_mmx == SDL_HasMMX())" was actually broken.
I think there is potentially a slightly different cause of the above problem.
During the introduction of the Altivec code, the blit_table struct field
'alpha' got changed from a straightforward enum to a bitmask, which makes
perfect sense by itself. However, now the table driven blitter selection code
in SDL_CalculateBlitN() can choose the wrong blitters when searching for a
NO_ALPHA blitter because of the following code:
int a_need = 0;
...
(a_need & table[which].alpha) == a_need &&
When searching through the normal_blit_2[] table, a SET_ALPHA blitter (like
Blit_RGB565_ARGB8888) can now be selected instead of a NO_ALPHA one, causing
alpha channel bits to appear in a non-alpha destination surface. I suppose this
could theoretically be an indirect cause of the segfault mentioned above.
I *think* this can be fixed by changing to
int a_need = NO_ALPHA;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 15 Mar 2006 15:47:49 +0000 |
parents | 67781f790694 |
children | e20dcef5647c |
line wrap: on
line source
Summary: Simple DirectMedia Layer Name: SDL Version: @SDL_VERSION@ Release: 1 Source: http://www.libsdl.org/release/%{name}-%{version}.tar.gz URL: http://www.libsdl.org/ License: LGPL Group: System Environment/Libraries BuildRoot: %{_tmppath}/%{name}-%{version}-buildroot Prefix: %{_prefix} %ifos linux Provides: libSDL-1.1.so.0 %endif %description This is the Simple DirectMedia Layer, a generic API that provides low level access to audio, keyboard, mouse, and display framebuffer across multiple platforms. %package devel Summary: Libraries, includes and more to develop SDL applications. Group: Development/Libraries Requires: %{name} = %{version} %description devel This is the Simple DirectMedia Layer, a generic API that provides low level access to audio, keyboard, mouse, and display framebuffer across multiple platforms. This is the libraries, include files and other resources you can use to develop SDL applications. %prep %setup -q %build %ifos linux CFLAGS="$RPM_OPT_FLAGS" ./configure --prefix=%{prefix} --disable-video-svga --disable-video-ggi --disable-video-aalib --disable-debug --enable-dlopen --enable-esd-shared --enable-arts-shared %else %configure --disable-debug --enable-dlopen %endif make %install rm -rf $RPM_BUILD_ROOT %ifos linux make install prefix=$RPM_BUILD_ROOT%{prefix} \ bindir=$RPM_BUILD_ROOT%{_bindir} \ libdir=$RPM_BUILD_ROOT%{_libdir} \ includedir=$RPM_BUILD_ROOT%{_includedir} \ datadir=$RPM_BUILD_ROOT%{_datadir} \ mandir=$RPM_BUILD_ROOT%{_mandir} ln -s libSDL-1.2.so.0 $RPM_BUILD_ROOT%{prefix}/lib/libSDL-1.1.so.0 %else %makeinstall %endif %clean rm -rf $RPM_BUILD_ROOT %ifnos darwin %define __defattr %defattr(-,root,root) %define __soext so %else %define __defattr %defattr(-,root,wheel) %define __soext dylib %endif %files %{__defattr} %doc README-SDL.txt COPYING CREDITS BUGS %ifnos darwin %{_libdir}/lib*.%{__soext}.* %else %{_libdir}/lib*.*.%{__soext} %endif %files devel %defattr(-,root,root) %doc README README-SDL.txt COPYING CREDITS BUGS WhatsNew docs.html %doc docs/index.html docs/html %{_bindir}/*-config %{_libdir}/lib*.a %{_libdir}/lib*.la %{_libdir}/lib*.%{__soext} %dir %{_includedir}/SDL %{_includedir}/SDL/*.h %{_datadir}/aclocal/* %{_mandir}/man3/* %changelog * Mon Jan 03 2004 Anders Bjorklund <afb@algonet.se> - Added support for Darwin, updated spec file * Wed Jan 19 2000 Sam Lantinga <slouken@libsdl.org> - Re-integrated spec file into SDL distribution - 'name' and 'version' come from configure - Some of the documentation is devel specific - Removed SMP support from %build - it doesn't work with libtool anyway * Tue Jan 18 2000 Hakan Tandogan <hakan@iconsult.com> - Hacked Mandrake sdl spec to build 1.1 * Sun Dec 19 1999 John Buswell <johnb@mandrakesoft.com> - Build Release * Sat Dec 18 1999 John Buswell <johnb@mandrakesoft.com> - Add symlink for libSDL-1.0.so.0 required by sdlbomber - Added docs * Thu Dec 09 1999 Lenny Cartier <lenny@mandrakesoft.com> - v 1.0.0 * Mon Nov 1 1999 Chmouel Boudjnah <chmouel@mandrakesoft.com> - First spec file for Mandrake distribution. # end of file