Mercurial > sdl-ios-xcode
view src/audio/dart/SDL_dart.h @ 1626:a80e1e0880b8
Fixed bug #176
[I'm fixing this for the public headers, but I'm not going to bother for the SDL library code (yet)]
To clarify: Normaly, GCC (or, to be precise, the preprocessor) will ignore
this, and compile the code happily. However, one can specify -Wundef to get a
warning about this.
One can probably argue whether to consider this a bug or not; but I think that
(a) from a semantic point of view, using "#if FOO" when FOO is not defined is
strange, and (b) since it is possible to trigger a warning about this, and a
trivial fix exists, it should be corrected.
I can think of two alternative patches, BTW:
1) Simply use #define HAVE_FOO 0, instead of not defining HAVE_FOO at all
2) Change
#if HAVE_FOO
to
#if HAVE_FOO+0
which always does the right thing.
But I think I still prefer the attached patch :-).
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Thu, 13 Apr 2006 13:38:40 +0000 |
parents | d910939febfa |
children | 782fd950bd46 a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef _SDL_lowaudio_h #define _SDL_lowaudio_h #define INCL_TYPES #define INCL_DOSSEMAPHORES #define INCL_DOSRESOURCES #define INCL_DOSMISC #define INCL_DOSERRORS #define INCL_OS2MM #define INCL_MMIOOS2 #define INCL_MCIOS2 #include <os2.h> #include <os2me.h> // DART stuff and MMIO stuff #include "../SDL_sysaudio.h" /* Hidden "this" pointer for the audio functions */ #define _THIS SDL_AudioDevice *_this /* The DirectSound objects */ struct SDL_PrivateAudioData { int iCurrDeviceOrd; int iCurrFreq; int iCurrBits; int iCurrChannels; int iCurrNumBufs; int iCurrBufSize; int iLastPlayedBuf; int iNextFreeBuffer; MCI_BUFFER_PARMS BufferParms; // Sound buffer parameters MCI_MIX_BUFFER *pMixBuffers; // Sound buffers MCI_MIXSETUP_PARMS MixSetupParms; // Mixer setup parameters HEV hevAudioBufferPlayed; // Event semaphore to indicate that an audio buffer has been played by DART }; #endif /* _SDL_lowaudio_h */