Mercurial > sdl-ios-xcode
view src/SDL_error_c.h @ 1626:a80e1e0880b8
Fixed bug #176
[I'm fixing this for the public headers, but I'm not going to bother for the SDL library code (yet)]
To clarify: Normaly, GCC (or, to be precise, the preprocessor) will ignore
this, and compile the code happily. However, one can specify -Wundef to get a
warning about this.
One can probably argue whether to consider this a bug or not; but I think that
(a) from a semantic point of view, using "#if FOO" when FOO is not defined is
strange, and (b) since it is possible to trigger a warning about this, and a
trivial fix exists, it should be corrected.
I can think of two alternative patches, BTW:
1) Simply use #define HAVE_FOO 0, instead of not defining HAVE_FOO at all
2) Change
#if HAVE_FOO
to
#if HAVE_FOO+0
which always does the right thing.
But I think I still prefer the attached patch :-).
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Thu, 13 Apr 2006 13:38:40 +0000 |
parents | d910939febfa |
children | 14717b52abc0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* This file defines a structure that carries language-independent error messages */ #ifndef _SDL_error_c_h #define _SDL_error_c_h #define ERR_MAX_STRLEN 128 #define ERR_MAX_ARGS 5 typedef struct SDL_error { /* This is a numeric value corresponding to the current error */ int error; /* This is a key used to index into a language hashtable containing internationalized versions of the SDL error messages. If the key is not in the hashtable, or no hashtable is available, the key is used directly as an error message format string. */ unsigned char key[ERR_MAX_STRLEN]; /* These are the arguments for the error functions */ int argc; union { void *value_ptr; #if 0 /* What is a character anyway? (UNICODE issues) */ unsigned char value_c; #endif int value_i; double value_f; unsigned char buf[ERR_MAX_STRLEN]; } args[ERR_MAX_ARGS]; } SDL_error; #endif /* _SDL_error_c_h */