Mercurial > sdl-ios-xcode
view src/video/directfb/SDL_DirectFB_dyn.c @ 4425:a3e71b957215
Fixed bug #961
Kalle Olavi Niemitalo 2010-02-28 09:15:50 PST
It seems the SDLK_LMETA and SDLK_RMETA constants have been removed from SDL
1.3. I grepped for them in the SDL source tree and these were the only hits:
./include/SDL_compat.h:230:#define SDLK_LSUPER SDLK_LMETA
./include/SDL_compat.h:231:#define SDLK_RSUPER SDLK_RMETA
./src/video/bwindow/SDL_BWin.h:194: keymap[0x66] = SDLK_LMETA;
./src/video/bwindow/SDL_BWin.h:195: keymap[0x67] = SDLK_RMETA;
I don't know how compatible SDL 1.3 is supposed to be with applications
designed for SDL 1.2. However, as you can see, SDL itself is still trying to
use the removed constants, and that is clearly a bug.
Because SDL_compat.h defines KMOD_LMETA as KMOD_LGUI, I suppose it should also
define SDLK_LMETA as SDLK_LGUI, and SDLK_RMETA likewise.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 09 Mar 2010 06:07:48 +0000 |
parents | f7b03b6838cb |
children | b196d2758026 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #include "SDL_DirectFB_video.h" #include "SDL_DirectFB_dyn.h" #ifdef SDL_VIDEO_DRIVER_DIRECTFB_DYNAMIC #include "SDL_name.h" #include "SDL_loadso.h" #define DFB_SYM(ret, name, args, al, func) ret (*name) args; static struct _SDL_DirectFB_Symbols { DFB_SYMS const unsigned int *directfb_major_version; const unsigned int *directfb_minor_version; const unsigned int *directfb_micro_version; } SDL_DirectFB_Symbols; #undef DFB_SYM #define DFB_SYM(ret, name, args, al, func) ret name args { func SDL_DirectFB_Symbols.name al ; } DFB_SYMS #undef DFB_SYM static void *handle = NULL; int SDL_DirectFB_LoadLibrary(void) { int retval = 0; if (handle == NULL) { handle = SDL_LoadObject(SDL_VIDEO_DRIVER_DIRECTFB_DYNAMIC); if (handle != NULL) { retval = 1; #define DFB_SYM(ret, name, args, al, func) if (!(SDL_DirectFB_Symbols.name = SDL_LoadFunction(handle, # name))) retval = 0; DFB_SYMS #undef DFB_SYM if (! (SDL_DirectFB_Symbols.directfb_major_version = SDL_LoadFunction(handle, "directfb_major_version"))) retval = 0; if (! (SDL_DirectFB_Symbols.directfb_minor_version = SDL_LoadFunction(handle, "directfb_minor_version"))) retval = 0; if (! (SDL_DirectFB_Symbols.directfb_micro_version = SDL_LoadFunction(handle, "directfb_micro_version"))) retval = 0; } } if (retval) { const char *stemp = DirectFBCheckVersion(DIRECTFB_MAJOR_VERSION, DIRECTFB_MINOR_VERSION, DIRECTFB_MICRO_VERSION); /* Version Check */ if (stemp != NULL) { fprintf(stderr, "DirectFB Lib: Version mismatch. Compiled: %d.%d.%d Library %d.%d.%d\n", DIRECTFB_MAJOR_VERSION, DIRECTFB_MINOR_VERSION, DIRECTFB_MICRO_VERSION, *SDL_DirectFB_Symbols.directfb_major_version, *SDL_DirectFB_Symbols.directfb_minor_version, *SDL_DirectFB_Symbols.directfb_micro_version); retval = 0; } } if (!retval) SDL_DirectFB_UnLoadLibrary(); return retval; } void SDL_DirectFB_UnLoadLibrary(void) { if (handle != NULL) { SDL_UnloadObject(handle); handle = NULL; } } #else int SDL_DirectFB_LoadLibrary(void) { return 1; } void SDL_DirectFB_UnLoadLibrary(void) { } #endif