Mercurial > sdl-ios-xcode
view src/video/x11/SDL_x11dga.c @ 4393:9afe12fb4c41 SDL-1.2
Fixed bug #901
Tim Angus 2009-12-11 11:45:46 PST
Disable mouse event generation when state is not SDL_APPMOUSEFOCUS
If a Windows SDL application is minimised by using alt-tab, SDL_APPMOUSEFOCUS
is lost as part of the minimisation. Unfortunately, the directx driver doesn't
pay any attention to this state when generating mouse button events, so
clicking on the Desktop can cause mouse clicks in the SDL application, while
it's still minimised. The attached patch fixes this. It looks much more
complicated than it actually is due to indentation; here it is ignoring
whitespace:
tma@abraxas:~/sources/SDL-1.2-svn$ svn diff -x -b
Index: src/video/windx5/SDL_dx5events.c
===================================================================
--- src/video/windx5/SDL_dx5events.c (revision 5376)
+++ src/video/windx5/SDL_dx5events.c (working copy)
@@ -374,10 +374,9 @@
if ( !(SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) {
mouse_lost = 1;
ClipCursor(NULL);
- }
-
+ } else {
/* If the mouse was lost, regain some sense of mouse state */
- if ( mouse_lost && (SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) {
+ if ( mouse_lost ) {
POINT mouse_pos;
Uint8 old_state;
Uint8 new_state;
@@ -548,6 +547,7 @@
if ( xrel || yrel ) {
post_mouse_motion(1, xrel, yrel);
}
+ }
}
/* The main Win32 event handler */
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 14 Dec 2009 22:41:31 +0000 |
parents | a1b03ba2fcd0 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* This is currently only used to enable DGA mouse. There is a completely separate DGA driver that is fullscreen-only. */ #include "SDL_video.h" #include "../SDL_cursor_c.h" #include "SDL_x11dga_c.h" /* Global for the error handler */ int dga_event, dga_error = -1; void X11_EnableDGAMouse(_THIS) { #if SDL_VIDEO_DRIVER_X11_DGAMOUSE static int use_dgamouse = -1; /* Check configuration to see if we should use DGA mouse */ if ( use_dgamouse < 0 ) { int dga_major, dga_minor; int dga_flags; const char *env_use_dgamouse; use_dgamouse = 1; env_use_dgamouse = SDL_getenv("SDL_VIDEO_X11_DGAMOUSE"); if ( env_use_dgamouse ) { use_dgamouse = SDL_atoi(env_use_dgamouse); } /* Check for buggy X servers */ if ( use_dgamouse && BUGGY_XFREE86(==, 4000) ) { use_dgamouse = 0; } if ( !use_dgamouse || !local_X11 || !SDL_NAME(XF86DGAQueryExtension)(SDL_Display, &dga_event, &dga_error) || !SDL_NAME(XF86DGAQueryVersion)(SDL_Display, &dga_major, &dga_minor) || !SDL_NAME(XF86DGAQueryDirectVideo)(SDL_Display, SDL_Screen, &dga_flags) || !(dga_flags & XF86DGADirectPresent) ) { use_dgamouse = 0; } } if ( use_dgamouse && !(using_dga & DGA_MOUSE) ) { if ( SDL_NAME(XF86DGADirectVideo)(SDL_Display, SDL_Screen, XF86DGADirectMouse) ) { using_dga |= DGA_MOUSE; } } #endif /* SDL_VIDEO_DRIVER_X11_DGAMOUSE */ } /* Argh. Glide resets DGA mouse mode when it makes the context current! */ void X11_CheckDGAMouse(_THIS) { #if SDL_VIDEO_DRIVER_X11_DGAMOUSE if ( using_dga & DGA_MOUSE ) { SDL_NAME(XF86DGADirectVideo)(SDL_Display,SDL_Screen,XF86DGADirectMouse); } #endif } void X11_DisableDGAMouse(_THIS) { #if SDL_VIDEO_DRIVER_X11_DGAMOUSE if ( using_dga & DGA_MOUSE ) { SDL_NAME(XF86DGADirectVideo)(SDL_Display, SDL_Screen, 0); using_dga &= ~DGA_MOUSE; } #endif /* SDL_VIDEO_DRIVER_X11_DGAMOUSE */ }