Mercurial > sdl-ios-xcode
view SDL.spec.in @ 4158:96ce26f24b01 SDL-1.2
Date: Sun, 7 Sep 2008 15:17:00 +0200
From: c2woody@gmx.net
Subject: [SDL] SDL 1.2 doube free/pointer zeroing missing
Hello,
this is about a crash/debug breakage for the current SDL 1.2
source tree (today's svn checkout, same problem in 1.2.13 and
before as far as relevant).
In some places memory is free()d but the associated pointer
is not zeroed, leading to for example double free()s.
For me this happened because SDL_StopEventThread() was executed
twice (during restart of the subsystems), once for the close
down in SDL_VideoQuit() and once at the startup, right at the
beginning of SDL_StartEventLoop(). Thus the code
SDL_DestroyMutex(SDL_EventQ.lock);
(see SDL_events.c) was called twice and executed the SDL_free(mutex);
twice as well, leading to a crash (msvc 64bit for which it was noticed).
I've tried to check all other occurrences of SDL_free and similar
code in msvc, see the attached patch (udiff against revision 4082).
Non-windows only codepaths have neither been checked nor touched.
Comments/ideas welcome.
Attached patch: NULLifies some pointers after they have been free()d.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 12 Nov 2008 17:23:40 +0000 |
parents | 56ec4d962487 |
children | 17376128fb56 |
line wrap: on
line source
Summary: Simple DirectMedia Layer Name: SDL Version: @SDL_VERSION@ Release: 1 Source: http://www.libsdl.org/release/%{name}-%{version}.tar.gz URL: http://www.libsdl.org/ License: LGPL Group: System Environment/Libraries BuildRoot: %{_tmppath}/%{name}-%{version}-buildroot Prefix: %{_prefix} %ifos linux Provides: libSDL-1.2.so.0 %endif %define __defattr %defattr(-,root,root) %define __soext so %description This is the Simple DirectMedia Layer, a generic API that provides low level access to audio, keyboard, mouse, and display framebuffer across multiple platforms. %package devel Summary: Libraries, includes and more to develop SDL applications. Group: Development/Libraries Requires: %{name} = %{version} %description devel This is the Simple DirectMedia Layer, a generic API that provides low level access to audio, keyboard, mouse, and display framebuffer across multiple platforms. This is the libraries, include files and other resources you can use to develop SDL applications. %prep %setup -q %build %ifos linux CFLAGS="$RPM_OPT_FLAGS" ./configure --prefix=%{prefix} --disable-video-aalib --disable-video-directfb --disable-video-ggi --disable-video-svga %else %configure %endif make %install rm -rf $RPM_BUILD_ROOT %ifos linux make install prefix=$RPM_BUILD_ROOT%{prefix} \ bindir=$RPM_BUILD_ROOT%{_bindir} \ libdir=$RPM_BUILD_ROOT%{_libdir} \ includedir=$RPM_BUILD_ROOT%{_includedir} \ datadir=$RPM_BUILD_ROOT%{_datadir} \ mandir=$RPM_BUILD_ROOT%{_mandir} ln -s libSDL-1.2.so.0 $RPM_BUILD_ROOT%{_libdir}/libSDL-1.1.so.0 %else %makeinstall %endif %clean rm -rf $RPM_BUILD_ROOT %files %{__defattr} %doc README-SDL.txt COPYING CREDITS BUGS %{_libdir}/lib*.%{__soext}.* %files devel %{__defattr} %doc README README-SDL.txt COPYING CREDITS BUGS WhatsNew docs.html %doc docs/index.html docs/html %{_bindir}/*-config %{_libdir}/lib*.a %{_libdir}/lib*.la %{_libdir}/lib*.%{__soext} %dir %{_includedir}/SDL %{_includedir}/SDL/*.h %{_libdir}/pkgconfig/sdl.pc %{_datadir}/aclocal/* %{_mandir}/man3/* %changelog * Tue May 16 2006 Sam Lantinga <slouken@libsdl.org> - Removed support for Darwin, due to build problems on ps2linux * Mon Jan 03 2004 Anders Bjorklund <afb@algonet.se> - Added support for Darwin, updated spec file * Wed Jan 19 2000 Sam Lantinga <slouken@libsdl.org> - Re-integrated spec file into SDL distribution - 'name' and 'version' come from configure - Some of the documentation is devel specific - Removed SMP support from %build - it doesn't work with libtool anyway * Tue Jan 18 2000 Hakan Tandogan <hakan@iconsult.com> - Hacked Mandrake sdl spec to build 1.1 * Sun Dec 19 1999 John Buswell <johnb@mandrakesoft.com> - Build Release * Sat Dec 18 1999 John Buswell <johnb@mandrakesoft.com> - Add symlink for libSDL-1.0.so.0 required by sdlbomber - Added docs * Thu Dec 09 1999 Lenny Cartier <lenny@mandrakesoft.com> - v 1.0.0 * Mon Nov 1 1999 Chmouel Boudjnah <chmouel@mandrakesoft.com> - First spec file for Mandrake distribution. # end of file