Mercurial > sdl-ios-xcode
view README.SVN @ 4158:96ce26f24b01 SDL-1.2
Date: Sun, 7 Sep 2008 15:17:00 +0200
From: c2woody@gmx.net
Subject: [SDL] SDL 1.2 doube free/pointer zeroing missing
Hello,
this is about a crash/debug breakage for the current SDL 1.2
source tree (today's svn checkout, same problem in 1.2.13 and
before as far as relevant).
In some places memory is free()d but the associated pointer
is not zeroed, leading to for example double free()s.
For me this happened because SDL_StopEventThread() was executed
twice (during restart of the subsystems), once for the close
down in SDL_VideoQuit() and once at the startup, right at the
beginning of SDL_StartEventLoop(). Thus the code
SDL_DestroyMutex(SDL_EventQ.lock);
(see SDL_events.c) was called twice and executed the SDL_free(mutex);
twice as well, leading to a crash (msvc 64bit for which it was noticed).
I've tried to check all other occurrences of SDL_free and similar
code in msvc, see the attached patch (udiff against revision 4082).
Non-windows only codepaths have neither been checked nor touched.
Comments/ideas welcome.
Attached patch: NULLifies some pointers after they have been free()d.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 12 Nov 2008 17:23:40 +0000 |
parents | dc726b233f5f |
children |
line wrap: on
line source
The latest development version of SDL is available via Subversion. Subversion allows you to get up-to-the-minute fixes and enhancements; as a developer works on a source tree, you can use svn to mirror that source tree instead of waiting for an official release. Please look at the Subversion website ( http://subversion.tigris.org/ ) for more information on using svn, where you can also download software for MacOS, Windows, and Unix systems. svn checkout http://svn.libsdl.org/branches/SDL-1.2 If you are building SDL with an IDE, you will need to copy the file include/SDL_config.h.default to include/SDL_config.h before building. If you are building SDL via configure, you will need to run autogen.sh before running configure. There is a web interface to the subversion repository at: http://www.libsdl.org/cgi/viewvc.cgi There is an RSS feed available at that URL, for those that want to track commits in real time.