Mercurial > sdl-ios-xcode
view src/video/xbios/SDL_xbios_sb3.c @ 1120:8e1fde455471
Patch by me to fix crash described below.
--ryan.
To: sdl@libsdl.org
From: Rainer Deyke <rainerd@eldwood.com>
Date: Tue, 16 Aug 2005 01:08:18 -0600
Subject: [SDL] Bug report: SDL_CreateRGBSurface with SDL_HWSURFACE crashes
If SDL is in full-screen mode with a hardware video surface on OS X,
SDL_CreateRGBSurface with SDL_HWSURFACE crashes. The crash occurs on
line 109 of SDL_Surface.c. This was tested on OS X 10.3.9 with both SDL
1.2.8 and the latest CVS. Here is a small C++ program that demonstrates
the problem:
#include "SDL.h"
#include <stdio.h>
namespace {
void wait_for_key()
{
SDL_Event e;
printf("%d\n", SDL_GetAppState());
while (SDL_WaitEvent(&e)) {
if (e.type == SDL_KEYDOWN || e.type == SDL_QUIT) return;
}
}
}
int main(int, char *[])
{
SDL_Init(SDL_INIT_VIDEO);
SDL_Surface *screen
= SDL_SetVideoMode(640, 480, 32, SDL_FULLSCREEN | SDL_HWSURFACE);
SDL_Surface *s = SDL_CreateRGBSurface(SDL_HWSURFACE, 640, 480, 32,
screen->format->Rmask, screen->format->Gmask,
screen->format->Bmask, screen->format->Amask);
wait_for_key();
if (s) SDL_FreeSurface(s);
SDL_Quit();
printf("Success!\n");
return 0;
}
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Thu, 18 Aug 2005 06:46:32 +0000 |
parents | fba6b67b4d60 |
children | 3692456e7b0f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ /* ScreenBlaster 3 functions Patrice Mandin */ /*--- Includes ---*/ #include <stdlib.h> #include "SDL_xbios.h" #include "SDL_xbios_sb3.h" /*--- Defines ---*/ const int SDL_XBIOS_scpn_planes_device[]={ SCPN_DEV_1BPP, SCPN_DEV_4BPP, SCPN_DEV_8BPP, SCPN_DEV_16BPP, SCPN_DEV_2BPP, SCPN_DEV_4BPP, SCPN_DEV_1BPP }; /*--- Functions ---*/ int SDL_XBIOS_SB3Usable(scpn_cookie_t *cookie_scpn) { scpn_screeninfo_t *scrinfo; int bpp; /* Check if current SB3 mode is usable, i.e. 8 or 16bpp */ scrinfo = cookie_scpn->screen_info; bpp = 1<<(SDL_XBIOS_scpn_planes_device[scrinfo->device]); if ((bpp==8) || (bpp==16)) { return 1; } return 0; } void SDL_XBIOS_SB3Init(_THIS, scpn_cookie_t *cookie_scpn) { scpn_screeninfo_t *scrinfo; /* SB3 prevent changing video modes, we can only use current one */ if (XBIOS_modelist) { free(XBIOS_modelist); XBIOS_nummodes = 0; XBIOS_modelist = NULL; } scrinfo = cookie_scpn->screen_info; scrinfo->h_pos = scrinfo->v_pos = 0; SDL_XBIOS_AddMode(this, -1, scrinfo->virtual_width, scrinfo->virtual_height, 1<<(SDL_XBIOS_scpn_planes_device[scrinfo->device]), SDL_FALSE ); }