Patch by me to fix crash described below. --ryan. To: sdl@libsdl.org From: Rainer Deyke <rainerd@eldwood.com> Date: Tue, 16 Aug 2005 01:08:18 -0600 Subject: [SDL] Bug report: SDL_CreateRGBSurface with SDL_HWSURFACE crashes If SDL is in full-screen mode with a hardware video surface on OS X, SDL_CreateRGBSurface with SDL_HWSURFACE crashes. The crash occurs on line 109 of SDL_Surface.c. This was tested on OS X 10.3.9 with both SDL 1.2.8 and the latest CVS. Here is a small C++ program that demonstrates the problem: #include "SDL.h" #include <stdio.h> namespace { void wait_for_key() { SDL_Event e; printf("%d\n", SDL_GetAppState()); while (SDL_WaitEvent(&e)) { if (e.type == SDL_KEYDOWN || e.type == SDL_QUIT) return; } } } int main(int, char *[]) { SDL_Init(SDL_INIT_VIDEO); SDL_Surface *screen = SDL_SetVideoMode(640, 480, 32, SDL_FULLSCREEN | SDL_HWSURFACE); SDL_Surface *s = SDL_CreateRGBSurface(SDL_HWSURFACE, 640, 480, 32, screen->format->Rmask, screen->format->Gmask, screen->format->Bmask, screen->format->Amask); wait_for_key(); if (s) SDL_FreeSurface(s); SDL_Quit(); printf("Success!\n"); return 0; }

## Makefile.am for SDL using the framebuffer console video driver

noinst_LTLIBRARIES = libvideo_fbcon.la
libvideo_fbcon_la_SOURCES = $(FBCON_SRCS)

# The SDL framebuffer console video driver sources
FBCON_SRCS = 			\
	SDL_fbkeys.h		\
	SDL_fbvideo.h		\
	SDL_fbelo.c \
	SDL_fbelo.h \
	SDL_fbevents.c		\
	SDL_fbevents_c.h	\
	SDL_fb3dfx.c		\
	SDL_fb3dfx.h		\
	SDL_fbmatrox.c		\
	SDL_fbmatrox.h		\
	SDL_fbmouse.c		\
	SDL_fbmouse_c.h		\
	SDL_fbriva.c		\
	SDL_fbriva.h		\
	SDL_fbvideo.c		\
	3dfx_mmio.h		\
	3dfx_regs.h		\
	matrox_mmio.h		\
	matrox_regs.h		\
	riva_mmio.h		\
	riva_regs.h