Patch by me to fix crash described below. --ryan. To: sdl@libsdl.org From: Rainer Deyke <rainerd@eldwood.com> Date: Tue, 16 Aug 2005 01:08:18 -0600 Subject: [SDL] Bug report: SDL_CreateRGBSurface with SDL_HWSURFACE crashes If SDL is in full-screen mode with a hardware video surface on OS X, SDL_CreateRGBSurface with SDL_HWSURFACE crashes. The crash occurs on line 109 of SDL_Surface.c. This was tested on OS X 10.3.9 with both SDL 1.2.8 and the latest CVS. Here is a small C++ program that demonstrates the problem: #include "SDL.h" #include <stdio.h> namespace { void wait_for_key() { SDL_Event e; printf("%d\n", SDL_GetAppState()); while (SDL_WaitEvent(&e)) { if (e.type == SDL_KEYDOWN || e.type == SDL_QUIT) return; } } } int main(int, char *[]) { SDL_Init(SDL_INIT_VIDEO); SDL_Surface *screen = SDL_SetVideoMode(640, 480, 32, SDL_FULLSCREEN | SDL_HWSURFACE); SDL_Surface *s = SDL_CreateRGBSurface(SDL_HWSURFACE, 640, 480, 32, screen->format->Rmask, screen->format->Gmask, screen->format->Bmask, screen->format->Amask); wait_for_key(); if (s) SDL_FreeSurface(s); SDL_Quit(); printf("Success!\n"); return 0; }

## Makefile.am for the SDL video library

noinst_LTLIBRARIES = libvideo.la

# Define which subdirectories need to be built
SUBDIRS = @VIDEO_SUBDIRS@
DIST_SUBDIRS = dummy x11 dga nanox fbcon directfb vgl svga ggi aalib \
               wincommon windib windx5 \
               maccommon macdsp macrom riscos quartz \
               bwindow ps2gs photon cybergfx epoc picogui \
               ataricommon xbios gem dc qtopia XFree86

DRIVERS = @VIDEO_DRIVERS@

# Include the architecture-independent sources
COMMON_SRCS =			\
	SDL_RLEaccel.c		\
	SDL_RLEaccel_c.h	\
	SDL_blit.c		\
	SDL_blit.h		\
	SDL_blit_0.c		\
	SDL_blit_1.c		\
	SDL_blit_A.c		\
	SDL_blit_N.c		\
	SDL_bmp.c		\
	SDL_cursor.c		\
	SDL_cursor_c.h		\
	SDL_gamma.c		\
	SDL_glfuncs.h		\
	SDL_leaks.h		\
	SDL_memops.h		\
	SDL_pixels.c		\
	SDL_pixels_c.h		\
	SDL_surface.c		\
	SDL_stretch.c		\
	SDL_stretch_c.h		\
	SDL_sysvideo.h		\
	SDL_video.c		\
	SDL_yuv.c		\
	SDL_yuvfuncs.h		\
	SDL_yuv_sw.c		\
	SDL_yuv_sw_c.h		\
	SDL_yuv_mmx.c		\
	mmx.h			\
	blank_cursor.h		\
	default_cursor.h

libvideo_la_SOURCES = $(COMMON_SRCS)
libvideo_la_LIBADD = $(DRIVERS)
libvideo_la_DEPENDENCIES = $(DRIVERS)