Mercurial > sdl-ios-xcode
view README.wscons @ 4105:84882a89ca50 SDL-1.2
Date: Thu, 27 Dec 2007 07:38:25 +0000
From: John Bartholomew
Subject: [SDL] SDL Semaphore implementation broken on Windows?
Hi,
Over the past couple of days, I've been battling with SDL, SDL_Mixer and SMPEG to try to find an audio hang bug. I believe I've found the problem, which I think is a race condition inside SDL's semaphore implementation (at least the Windows implementation). The semaphore code uses Windows' built in semaphore functions, but it also maintains a separate count value. This count value is updated with bare increment and decrement operations in SemPost and SemWaitTimeout - no locking primitives to protect them.
In tracking down the apparent audio bug, I found that at some point a semaphore's count value was being decremented to -1, which is clearly not a valid value for it to take.
I'm still not certain exactly what sequence of operations is occuring for this to happen, but I believe that overall it's a race condition between a thread calling SemPost (which increments the count) and the thread on the other end calling SemWait (which decrements it).
I will try to make a test case to verify this, but I'm not sure if I'll be able to (threading errors being difficult to reproduce even in the best circumstances).
However, assuming this is the cause of my problems, there is a very
simple fix:
Windows provides InterlockedIncrement() and InterlockedDecrement()
functions to perform increments and decrements which are guaranteed to be atomic. So the fix is in thread/win32/SDL_syssem.c: replace occurrences of --sem->count with InterlockedDecrement(&sem->count); and replace occurrences of ++sem->count with InterlockedIncrement(&sem->count);
This is using SDL v1.2.12, built with VC++ 2008 Express, running on a
Core 2 duo processor.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 28 Dec 2007 22:05:17 +0000 |
parents | 19d8949b4584 |
children |
line wrap: on
line source
============================================================================== Using the Simple DirectMedia Layer with OpenBSD/wscons ============================================================================== The wscons SDL driver can be used to run SDL programs on OpenBSD without running X. So far, the driver only runs on the Sharp Zaurus, but the driver is written to be easily extended for other machines. The main missing pieces are blitting routines for anything but 16 bit displays, and keycode maps for other keyboards. Also, there is no support for hardware palettes. There is currently no mouse support. To compile SDL with support for wscons, use the "--enable-video-wscons" option when running configure. I used the following command line: ./configure --disable-oss --disable-ltdl --enable-pthread-sem \ --disable-esd --disable-arts --disable-video-aalib \ --enable-openbsdaudio --enable-video-wscons \ --prefix=/usr/local --sysconfdir=/etc Setting the console device to use ================================= When starting an SDL program on a wscons console, the driver uses the current virtual terminal (usually /dev/ttyC0). To force the driver to use a specific terminal device, set the environment variable SDL_WSCONSDEV: bash$ SDL_WSCONSDEV=/dev/ttyC1 ./some-sdl-program This is especially useful when starting an SDL program from a remote login prompt (which is great for development). If you do this, and want to use keyboard input, you should avoid having some other program reading from the used virtual console (i.e., do not have a getty running). Rotating the display ==================== The display can be rotated by the wscons SDL driver. This is useful for the Sharp Zaurus, since the display hardware is wired so that it is correctly rotated only when the display is folded into "PDA mode." When using the Zaurus in "normal," or "keyboard" mode, the hardware screen is rotated 90 degrees anti-clockwise. To let the wscons SDL driver rotate the screen, set the environment variable SDL_VIDEO_WSCONS_ROTATION to "CW", "CCW", or "UD", for clockwise, counter clockwise, and upside-down rotation respectively. "CW" makes the screen appear correct on a Sharp Zaurus SL-C3100. When using rotation in the driver, a "shadow" frame buffer is used to hold the intermediary display, before blitting it to the actual hardware frame buffer. This slows down performance a bit. For completeness, the rotation "NONE" can be specified to use a shadow frame buffer without actually rotating. Unsetting SDL_VIDEO_WSCONS_ROTATION, or setting it to '' turns off the shadow frame buffer for maximum performance. Running MAME ============ Since my main motivation for writing the driver was playing MAME on the Zaurus, I'll give a few hints: XMame compiles just fine under OpenBSD. I'm not sure this is strictly necessary, but set MY_CPU = arm in makefile.unix, and CFLAGS.arm = -DLSB_FIRST -DALIGN_INTS -DALIGN_SHORTS in src/unix/unix.max to be sure. The latest XMame (0.101 at this writing) is a very large program. Either tinker with the make files to compile a version without support for all drivers, or, get an older version of XMame. My recommendation would be 0.37b16. When running MAME, DO NOT SET SDL_VIDEO_WSCONS_ROTATION! Performace is MUCH better without this, and it is COMPLETELY UNNECESSARY, since MAME can rotate the picture itself while drawing, and does so MUCH FASTER. Use the Xmame command line option "-ror" to rotate the picture to the right. Acknowledgments =============== I studied the wsfb driver for XFree86/Xorg quite a bit before writing this, so there ought to be some similarities. -- Staffan Ulfberg <staffan@ulfberg.se>