Mercurial > sdl-ios-xcode
view CREDITS @ 983:7f08bd66f1ca
Date: Fri, 19 Nov 2004 06:23:53 -0800 (PST)
From: Eric Wing
Subject: OS X Mouse inversion problem fix (again)
Here's yet another patch for the OS X mouse inversion
problem. This should fix the problem once and for all.
I know I've said this before, but *This time for
sure!* :)
If you recall, my last patch broke the non-OpenGL
windowed code and caused the inversion to occur there
instead. Max submitted a patch that partially reverted
the changes back which included the os version hack
which is currently the most recent CVS.
Aaron Sullivan identified and reported to the mailing
list the other day, that the last partial regression
of the code broke OS X 10.2. Looking over the results,
I'm thinking that I was slightly more successful than
I thought at unifying the code. I think I was trying
to unify the code base for OpenGL and non-OpenGL
windowed modes for all versions of the OS. It looks
like I failed at at unifying the OpenGL and non-OpenGL
code, but I did succeed at unifying the OS versions.
Thus, we no longer need the hack for the OS version
checks. The partial regression still included an OS
check which is what broke things for < 10.3.
Attached is the patch for SDL_QuartzWM.m. It basically
is a half-line change that removes one of the two
checks that decides if the mouse coordinates need to
be inverted, i.e:
if (system_version >= 0x1030 &&
(SDL_VideoSurface->flags & SDL_OPENGL) )
becomes this:
if(SDL_VideoSurface->flags & SDL_OPENGL)
With Aaron's outstanding help, we have collectively
tested:
windowed OpenGL
windowed non-OpenGL
fullscreen OpenGL
fullscreen non-OpenGL
under OS X 10.2 (Jaguar), 10.3 (Panther), and 10.4
(Tiger).
We don't have access to 10.0 or 10.1, but since the
original problem didn't materialize until 10.3, I'm
hopeful that testing 10.2 is sufficient. And now that
the code is uniform, I'm also hoping we'll be safe
moving forward to deal with future revisions of the OS
with this issue.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 21 Nov 2004 00:57:47 +0000 |
parents | 85ba077211bc |
children | c2c72a31f1bc |
line wrap: on
line source
Simple DirectMedia Layer CREDITS Thanks to everyone who made this possible, including: * Cliff Matthews, for giving me a reason to start this project. :) -- Executor rocks! *grin* * Scott Call, for making a home for SDL on the 'Net... Thanks! :) * The Linux Fund, C Magazine, Educational Technology Resources Inc., Gareth Noyce, Jesse Pavel, Keith Kitchin, Jeremy Horvath, Thomas Nicholson, Hans-Peter Gygax, the Eternal Lands Development Team, Lars Brubaker, and Phoenix Kokido for financial contributions * Gaëtan de Menten for writing the PHP and SQL behind the SDL website * Tim Jones for the new look of the SDL website * Marco Kraus for setting up SDL merchandise * Martin Donlon for his work on the SDL Documentation Project * Ryan Gordon for helping everybody out and keeping the dream alive. :) * Mattias Engdegård, for help with the Solaris port and lots of other help * Max Watson, Matt Slot, and Kyle for help with the MacOS Classic port * Stan Shebs, for the initial MacOS X port * Max Horn and Darrell Walisser for unflagging work on the MacOS X port * Patrick Trainor, Jim Boucher, and Mike Gorchak for the QNX Neutrino port * Carsten Griwodz for the AIX port * Gabriele Greco, for the Amiga port * Patrice Mandin, for the Atari port * Hannu Viitala for the EPOC port * Peter Valchev for nagging me about the OpenBSD port until I got it right. :) * Kent B Mein, for a place to do the IRIX port * Ash, for a place to do the OSF/1 Alpha port * David Sowsy, for help with the BeOS port * Eugenia Loli, for endless work on porting SDL games to BeOS * Jon Taylor for the GGI front-end * Paulus Esterhazy, for the Visual C++ testing and libraries * Brenda Tantzen, for Metrowerks CodeWarrior on MacOS * Chris Nentwich, for the Hermes assembly blitters * Michael Vance and Jim Kutter for the X11 OpenGL support * Stephane Peter, for the AAlib front-end and multi-threaded timer idea. * Jon Atkins for SDL_image, SDL_mixer and SDL_net documentation * Peter Wiklund, for the 1998 winning SDL logo, and Arto Hamara, Steven Wong, and Kent Mein for other logo entries. * Arne Claus, for the 2004 winning SDL logo, and Shandy Brown, Jac, Alex Lyman, Mikkel Gjoel, #Guy, Jonas Hartmann, Daniel Liljeberg, Ronald Sowa, DocD, Pekka Jaervinen, Patrick Avella, Erkki Kontilla, Levon Gavalian, Hal Emerich, David Wiktorsson, S. Schury and F. Hufsky, Ciska de Ruyver, Shredweat, Tyler Montbriand, Martin Andersson, Merlyn Wysard, Fernando Ibanez, David Miller, Andre Bommele, lovesby.com, Francisco Camenforte Torres, and David Igreja for other logo entries. * Bob Pendleton and David Olofson for being long time contributors to the SDL mailing list. * Everybody at Loki Software, Inc. for their great contributions! And a big hand to everyone else who gave me appreciation, advice, and suggestions, especially the good folks on the SDL mailing list. THANKS! :) -- Sam Lantinga <slouken@libsdl.org>