Mercurial > sdl-ios-xcode
view src/loadso/macos/SDL_sysloadso.c @ 3880:74e828c64315 SDL-1.2
Fixed bug #292
I might be on crack here.
It looks like SDL_ConvertMono() in src/audio/SDL_audiocvt.c adds the left and
right channels of a stereo stream together, and clamps the new mono channel if
it would overflow.
Shouldn't it be dividing by 2 to average the two sample points instead of
clamping? Otherwise the mono sample point's volume doubles in the conversion.
This would also make the conversion faster, as it replaces two branches per
sample frame with a bitwise shift.
--ryan.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 24 Sep 2006 15:45:37 +0000 |
parents | 92947e3a18db |
children | 782fd950bd46 c121d94672cb a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifdef SDL_LOADSO_MACOS /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ /* System dependent library loading routines */ #include <stdio.h> #include <string.h> #define OLDP2C 1 #include <Strings.h> #include <CodeFragments.h> #include <Errors.h> #include "SDL_loadso.h" void *SDL_LoadObject(const char *sofile) { void *handle = NULL; const char *loaderror = NULL; CFragConnectionID library_id; Ptr mainAddr; Str255 errName; OSErr error; char psofile[512]; SDL_strlcpy(psofile, sofile, SDL_arraysize(psofile)); error = GetSharedLibrary(C2PStr(psofile), kCompiledCFragArch, kLoadCFrag, &library_id, &mainAddr, errName); switch (error) { case noErr: loaderror = NULL; break; case cfragNoLibraryErr: loaderror = "Library not found"; break; case cfragUnresolvedErr: loaderror = "Unabled to resolve symbols"; break; case cfragNoPrivateMemErr: case cfragNoClientMemErr: loaderror = "Out of memory"; break; default: loaderror = "Unknown Code Fragment Manager error"; break; } if ( loaderror == NULL ) { handle = (void *)(library_id); } else { SDL_SetError("Failed loading %s: %s", sofile, loaderror); } return(handle); } void *SDL_LoadFunction(void *handle, const char *name) { void *symbol = NULL; const char *loaderror = NULL; CFragSymbolClass class; CFragConnectionID library_id = (CFragConnectionID)handle; char pname[512]; SDL_strlcpy(pname, name, SDL_arraysize(pname)); if ( FindSymbol(library_id, C2PStr(pname), (char **)&symbol, &class) != noErr ) { loaderror = "Symbol not found"; } if ( symbol == NULL ) { SDL_SetError("Failed loading %s: %s", name, loaderror); } return(symbol); } void SDL_UnloadObject(void *handle) { CFragConnectionID library_id; if ( handle != NULL ) { library_id = (CFragConnectionID)handle; CloseConnection(&library_id); } } #endif /* SDL_LOADSO_MACOS */