Mercurial > sdl-ios-xcode
view src/cdrom/macosx/CDPlayer.h @ 3880:74e828c64315 SDL-1.2
Fixed bug #292
I might be on crack here.
It looks like SDL_ConvertMono() in src/audio/SDL_audiocvt.c adds the left and
right channels of a stereo stream together, and clamps the new mono channel if
it would overflow.
Shouldn't it be dividing by 2 to average the two sample points instead of
clamping? Otherwise the mono sample point's volume doubles in the conversion.
This would also make the conversion faster, as it replaces two branches per
sample frame with a bitwise shift.
--ryan.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 24 Sep 2006 15:45:37 +0000 |
parents | dc6b59e925a2 |
children | 782fd950bd46 c121d94672cb a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef __CDPlayer__H__ #define __CDPlayer__H__ 1 #include <string.h> #include <Carbon/Carbon.h> #include <CoreFoundation/CoreFoundation.h> #include <AudioUnit/AudioUnit.h> #include "SDL.h" #include "SDL_thread.h" #include "SDL_mutex.h" #ifdef __cplusplus extern "C" { #endif typedef void (*CDPlayerCompletionProc)(SDL_CD *cdrom) ; void Lock (); void Unlock(); int LoadFile (const FSRef *ref, int startFrame, int endFrame); /* pass -1 to do nothing */ int ReleaseFile (); int PlayFile (); int PauseFile (); void SetCompletionProc (CDPlayerCompletionProc proc, SDL_CD *cdrom); int ReadTOCData (FSVolumeRefNum theVolume, SDL_CD *theCD); int ListTrackFiles (FSVolumeRefNum theVolume, FSRef *trackFiles, int numTracks); int DetectAudioCDVolumes (FSVolumeRefNum *volumes, int numVolumes); int GetCurrentFrame (); #ifdef __cplusplus }; #endif #endif /* __CD_Player__H__ */