Mercurial > sdl-ios-xcode
view src/audio/dart/SDL_dart.h @ 3880:74e828c64315 SDL-1.2
Fixed bug #292
I might be on crack here.
It looks like SDL_ConvertMono() in src/audio/SDL_audiocvt.c adds the left and
right channels of a stereo stream together, and clamps the new mono channel if
it would overflow.
Shouldn't it be dividing by 2 to average the two sample points instead of
clamping? Otherwise the mono sample point's volume doubles in the conversion.
This would also make the conversion faster, as it replaces two branches per
sample frame with a bitwise shift.
--ryan.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 24 Sep 2006 15:45:37 +0000 |
parents | d910939febfa |
children | 782fd950bd46 a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef _SDL_lowaudio_h #define _SDL_lowaudio_h #define INCL_TYPES #define INCL_DOSSEMAPHORES #define INCL_DOSRESOURCES #define INCL_DOSMISC #define INCL_DOSERRORS #define INCL_OS2MM #define INCL_MMIOOS2 #define INCL_MCIOS2 #include <os2.h> #include <os2me.h> // DART stuff and MMIO stuff #include "../SDL_sysaudio.h" /* Hidden "this" pointer for the audio functions */ #define _THIS SDL_AudioDevice *_this /* The DirectSound objects */ struct SDL_PrivateAudioData { int iCurrDeviceOrd; int iCurrFreq; int iCurrBits; int iCurrChannels; int iCurrNumBufs; int iCurrBufSize; int iLastPlayedBuf; int iNextFreeBuffer; MCI_BUFFER_PARMS BufferParms; // Sound buffer parameters MCI_MIX_BUFFER *pMixBuffers; // Sound buffers MCI_MIXSETUP_PARMS MixSetupParms; // Mixer setup parameters HEV hevAudioBufferPlayed; // Event semaphore to indicate that an audio buffer has been played by DART }; #endif /* _SDL_lowaudio_h */