Mercurial > sdl-ios-xcode
view src/SDL_fatal.c @ 3880:74e828c64315 SDL-1.2
Fixed bug #292
I might be on crack here.
It looks like SDL_ConvertMono() in src/audio/SDL_audiocvt.c adds the left and
right channels of a stereo stream together, and clamps the new mono channel if
it would overflow.
Shouldn't it be dividing by 2 to average the two sample points instead of
clamping? Otherwise the mono sample point's volume doubles in the conversion.
This would also make the conversion faster, as it replaces two branches per
sample frame with a bitwise shift.
--ryan.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 24 Sep 2006 15:45:37 +0000 |
parents | d910939febfa |
children | 782fd950bd46 c121d94672cb a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* General fatal signal handling code for SDL */ #ifdef HAVE_SIGNAL_H #include <signal.h> #include "SDL.h" #include "SDL_fatal.h" /* This installs some signal handlers for the more common fatal signals, so that if the programmer is lazy, the app doesn't die so horribly if the program crashes. */ static void SDL_Parachute(int sig) { signal(sig, SIG_DFL); SDL_Quit(); raise(sig); } static int SDL_fatal_signals[] = { SIGSEGV, #ifdef SIGBUS SIGBUS, #endif #ifdef SIGFPE SIGFPE, #endif #ifdef SIGQUIT SIGQUIT, #endif 0 }; void SDL_InstallParachute(void) { /* Set a handler for any fatal signal not already handled */ int i; #ifdef HAVE_SIGACTION struct sigaction action; for ( i=0; SDL_fatal_signals[i]; ++i ) { sigaction(SDL_fatal_signals[i], NULL, &action); if ( action.sa_handler == SIG_DFL ) { action.sa_handler = SDL_Parachute; sigaction(SDL_fatal_signals[i], &action, NULL); } } #ifdef SIGALRM /* Set SIGALRM to be ignored -- necessary on Solaris */ sigaction(SIGALRM, NULL, &action); if ( action.sa_handler == SIG_DFL ) { action.sa_handler = SIG_IGN; sigaction(SIGALRM, &action, NULL); } #endif #else void (*ohandler)(int); for ( i=0; SDL_fatal_signals[i]; ++i ) { ohandler = signal(SDL_fatal_signals[i], SDL_Parachute); if ( ohandler != SIG_DFL ) { signal(SDL_fatal_signals[i], ohandler); } } #endif /* HAVE_SIGACTION */ return; } void SDL_UninstallParachute(void) { /* Remove a handler for any fatal signal handled */ int i; #ifdef HAVE_SIGACTION struct sigaction action; for ( i=0; SDL_fatal_signals[i]; ++i ) { sigaction(SDL_fatal_signals[i], NULL, &action); if ( action.sa_handler == SDL_Parachute ) { action.sa_handler = SIG_DFL; sigaction(SDL_fatal_signals[i], &action, NULL); } } #else void (*ohandler)(int); for ( i=0; SDL_fatal_signals[i]; ++i ) { ohandler = signal(SDL_fatal_signals[i], SIG_DFL); if ( ohandler != SDL_Parachute ) { signal(SDL_fatal_signals[i], ohandler); } } #endif /* HAVE_SIGACTION */ } #else /* No signals on this platform, nothing to do.. */ void SDL_InstallParachute(void) { return; } void SDL_UninstallParachute(void) { return; } #endif /* HAVE_SIGNAL_H */