Mercurial > sdl-ios-xcode
view test/testplatform.c @ 5080:6d94060d16a9
Fixed bug #1011
Daniel Ellis 2010-06-25 15:20:31 PDT
SDL based applications sometimes display the wrong application name in the
Sound Preferences dialog when using pulseaudio.
I can see from the code that the SDL pulse module is initiating a new pulse
audio context and passing an application name using the function
get_progname().
The get_progname() function returns the name of the current process. However,
the process name is often not a suitable name to use. For example, the OpenShot
video editor is a python application, and so "python" is displayed in the Sound
Preferences window (see Bug #596504), when it should be displaying "OpenShot".
PulseAudio allows applications to specify the application name, either at the
time the context is created (as SDL does currently), or by special environment
variables (see http://www.pulseaudio.org/wiki/ApplicationProperties). If no
name is specified, then pulseaudio will determine the name based on the
process.
If you specify the application name when initiating the pulseaudio context,
then that will override any application name specified using an environment
variable.
As libsdl is a library, I believe the solution is for libsdl to not specify any
application name when initiating a pulseaudio context, which will enable
applications to specify the application name using environment variables. In
the case that the applications do not specify anything, pulseaudio will fall
back to using the process name anyway.
The attached patch removes the get_progname() function and passes NULL as the
application name when creating the pulseaudio context, which fixes the issue.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 23 Jan 2011 21:55:04 -0800 |
parents | 8e5186a99af4 |
children | 87f452305db4 |
line wrap: on
line source
#include <stdio.h> #include "SDL.h" #include "SDL_endian.h" #include "SDL_cpuinfo.h" #include "SDL_assert.h" /* * Watcom C flags these as Warning 201: "Unreachable code" if you just * compare them directly, so we push it through a function to keep the * compiler quiet. --ryan. */ static int badsize(size_t sizeoftype, size_t hardcodetype) { return sizeoftype != hardcodetype; } int TestTypes(SDL_bool verbose) { int error = 0; if (badsize(sizeof(Uint8), 1)) { if (verbose) printf("sizeof(Uint8) != 1, instead = %u\n", (unsigned int)sizeof(Uint8)); ++error; } if (badsize(sizeof(Uint16), 2)) { if (verbose) printf("sizeof(Uint16) != 2, instead = %u\n", (unsigned int)sizeof(Uint16)); ++error; } if (badsize(sizeof(Uint32), 4)) { if (verbose) printf("sizeof(Uint32) != 4, instead = %u\n", (unsigned int)sizeof(Uint32)); ++error; } #ifdef SDL_HAS_64BIT_TYPE if (badsize(sizeof(Uint64), 8)) { if (verbose) printf("sizeof(Uint64) != 8, instead = %u\n", (unsigned int)sizeof(Uint64)); ++error; } #else if (verbose) { printf("WARNING: No 64-bit datatype on this platform\n"); } #endif if (verbose && !error) printf("All data types are the expected size.\n"); return (error ? 1 : 0); } int TestEndian(SDL_bool verbose) { int error = 0; Uint16 value = 0x1234; int real_byteorder; Uint16 value16 = 0xCDAB; Uint16 swapped16 = 0xABCD; Uint32 value32 = 0xEFBEADDE; Uint32 swapped32 = 0xDEADBEEF; #ifdef SDL_HAS_64BIT_TYPE Uint64 value64, swapped64; value64 = 0xEFBEADDE; value64 <<= 32; value64 |= 0xCDAB3412; swapped64 = 0x1234ABCD; swapped64 <<= 32; swapped64 |= 0xDEADBEEF; #endif if (verbose) { printf("Detected a %s endian machine.\n", (SDL_BYTEORDER == SDL_LIL_ENDIAN) ? "little" : "big"); } if ((*((char *) &value) >> 4) == 0x1) { real_byteorder = SDL_BIG_ENDIAN; } else { real_byteorder = SDL_LIL_ENDIAN; } if (real_byteorder != SDL_BYTEORDER) { if (verbose) { printf("Actually a %s endian machine!\n", (real_byteorder == SDL_LIL_ENDIAN) ? "little" : "big"); } ++error; } if (verbose) { printf("Value 16 = 0x%X, swapped = 0x%X\n", value16, SDL_Swap16(value16)); } if (SDL_Swap16(value16) != swapped16) { if (verbose) { printf("16 bit value swapped incorrectly!\n"); } ++error; } if (verbose) { printf("Value 32 = 0x%X, swapped = 0x%X\n", value32, SDL_Swap32(value32)); } if (SDL_Swap32(value32) != swapped32) { if (verbose) { printf("32 bit value swapped incorrectly!\n"); } ++error; } #ifdef SDL_HAS_64BIT_TYPE if (verbose) { #ifdef _MSC_VER printf("Value 64 = 0x%I64X, swapped = 0x%I64X\n", value64, SDL_Swap64(value64)); #else printf("Value 64 = 0x%llX, swapped = 0x%llX\n", value64, SDL_Swap64(value64)); #endif } if (SDL_Swap64(value64) != swapped64) { if (verbose) { printf("64 bit value swapped incorrectly!\n"); } ++error; } #endif return (error ? 1 : 0); } int TestCPUInfo(SDL_bool verbose) { if (verbose) { printf("CPU count: %d\n", SDL_GetCPUCount()); printf("RDTSC %s\n", SDL_HasRDTSC()? "detected" : "not detected"); printf("MMX %s\n", SDL_HasMMX()? "detected" : "not detected"); printf("MMX Ext %s\n", SDL_HasMMXExt()? "detected" : "not detected"); printf("3DNow %s\n", SDL_Has3DNow()? "detected" : "not detected"); printf("3DNow Ext %s\n", SDL_Has3DNowExt()? "detected" : "not detected"); printf("SSE %s\n", SDL_HasSSE()? "detected" : "not detected"); printf("SSE2 %s\n", SDL_HasSSE2()? "detected" : "not detected"); printf("AltiVec %s\n", SDL_HasAltiVec()? "detected" : "not detected"); } return (0); } int TestAssertions(SDL_bool verbose) { SDL_assert(1); SDL_assert_release(1); SDL_assert_paranoid(1); SDL_assert(0 || 1); SDL_assert_release(0 || 1); SDL_assert_paranoid(0 || 1); #if 0 /* enable this to test assertion failures. */ SDL_assert_release(1 == 2); SDL_assert_release(5 < 4); SDL_assert_release(0 && "This is a test"); #endif SDL_assert_release(0 && "This is a test"); return (0); } int main(int argc, char *argv[]) { SDL_bool verbose = SDL_TRUE; int status = 0; if (argv[1] && (SDL_strcmp(argv[1], "-q") == 0)) { verbose = SDL_FALSE; } if (verbose) { printf("This system is running %s\n", SDL_GetPlatform()); } status += TestTypes(verbose); status += TestEndian(verbose); status += TestCPUInfo(verbose); status += TestAssertions(verbose); return status; }