Mercurial > sdl-ios-xcode
view test/testatomic.c @ 5080:6d94060d16a9
Fixed bug #1011
Daniel Ellis 2010-06-25 15:20:31 PDT
SDL based applications sometimes display the wrong application name in the
Sound Preferences dialog when using pulseaudio.
I can see from the code that the SDL pulse module is initiating a new pulse
audio context and passing an application name using the function
get_progname().
The get_progname() function returns the name of the current process. However,
the process name is often not a suitable name to use. For example, the OpenShot
video editor is a python application, and so "python" is displayed in the Sound
Preferences window (see Bug #596504), when it should be displaying "OpenShot".
PulseAudio allows applications to specify the application name, either at the
time the context is created (as SDL does currently), or by special environment
variables (see http://www.pulseaudio.org/wiki/ApplicationProperties). If no
name is specified, then pulseaudio will determine the name based on the
process.
If you specify the application name when initiating the pulseaudio context,
then that will override any application name specified using an environment
variable.
As libsdl is a library, I believe the solution is for libsdl to not specify any
application name when initiating a pulseaudio context, which will enable
applications to specify the application name using environment variables. In
the case that the applications do not specify anything, pulseaudio will fall
back to using the process name anyway.
The attached patch removes the get_progname() function and passes NULL as the
application name when creating the pulseaudio context, which fixes the issue.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 23 Jan 2011 21:55:04 -0800 |
parents | 9de326b3099c |
children | 3a95a2b93eb3 |
line wrap: on
line source
#include <stdio.h> #include "SDL.h" /* Make sure we have good macros for printing 32 and 64 bit values */ #ifndef PRIu32 #define PRIu32 "u" #endif #ifndef PRIu64 #ifdef __WIN32__ #define PRIu64 "I64u" #else #define PRIu64 "llu" #endif #endif /* Absolutely basic tests just to see if we get the expected value after calling each function. */ char * tf(SDL_bool tf) { static char *t = "true"; static char *f = "false"; if (tf) { return t; } return f; } int main(int argc, char *argv[]) { volatile Uint32 val32 = 0; Uint32 ret32 = 0; volatile Uint64 val64 = 0; Uint64 ret64 = 0; SDL_SpinLock lock = 0; SDL_bool tfret = SDL_FALSE; printf("\nspin lock---------------------------------------\n\n"); SDL_AtomicLock(&lock); printf("AtomicLock lock=%d\n", lock); SDL_AtomicUnlock(&lock); printf("AtomicUnlock lock=%d\n", lock); printf("\n32 bit -----------------------------------------\n\n"); val32 = 0; tfret = SDL_AtomicTestThenSet32(&val32); printf("TestThenSet32 tfret=%s val=%"PRIu32"\n", tf(tfret), val32); tfret = SDL_AtomicTestThenSet32(&val32); printf("TestThenSet32 tfret=%s val=%"PRIu32"\n", tf(tfret), val32); SDL_AtomicClear32(&val32); printf("Clear32 val=%"PRIu32"\n", val32); ret32 = SDL_AtomicFetchThenIncrement32(&val32); printf("FetchThenIncrement32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicFetchThenDecrement32(&val32); printf("FetchThenDecrement32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicFetchThenAdd32(&val32, 10); printf("FetchThenAdd32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicFetchThenSubtract32(&val32, 10); printf("FetchThenSubtract32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicIncrementThenFetch32(&val32); printf("IncrementThenFetch32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicDecrementThenFetch32(&val32); printf("DecrementThenFetch32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicAddThenFetch32(&val32, 10); printf("AddThenFetch32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); ret32 = SDL_AtomicSubtractThenFetch32(&val32, 10); printf("SubtractThenFetch32 ret=%"PRIu32" val=%"PRIu32"\n", ret32, val32); #ifdef SDL_HAS_64BIT_TYPE printf("\n64 bit -----------------------------------------\n\n"); val64 = 0; tfret = SDL_AtomicTestThenSet64(&val64); printf("TestThenSet64 tfret=%s val=%"PRIu64"\n", tf(tfret), val64); tfret = SDL_AtomicTestThenSet64(&val64); printf("TestThenSet64 tfret=%s val=%"PRIu64"\n", tf(tfret), val64); SDL_AtomicClear64(&val64); printf("Clear64 val=%"PRIu64"\n", val64); ret64 = SDL_AtomicFetchThenIncrement64(&val64); printf("FetchThenIncrement64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicFetchThenDecrement64(&val64); printf("FetchThenDecrement64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicFetchThenAdd64(&val64, 10); printf("FetchThenAdd64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicFetchThenSubtract64(&val64, 10); printf("FetchThenSubtract64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicIncrementThenFetch64(&val64); printf("IncrementThenFetch64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicDecrementThenFetch64(&val64); printf("DecrementThenFetch64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicAddThenFetch64(&val64, 10); printf("AddThenFetch64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); ret64 = SDL_AtomicSubtractThenFetch64(&val64, 10); printf("SubtractThenFetch64 ret=%"PRIu64" val=%"PRIu64"\n", ret64, val64); #endif return 0; }