Mercurial > sdl-ios-xcode
view src/events/SDL_quit.c @ 4168:69bcba65c388 SDL-1.2
Fixed bug #526
Comment #1 From Simon Howard 2009-03-20 16:50:56
Hi,
I'm the author of Chocolate Doom, one of the other source ports that James
mentioned. This is a patch against the current SVN version of SDL 1.2 that
fixes the bug. It has been tested and hopefully should be obviously correct
from examining the changes. I'll give a brief explanation.
When the palette is set with SDL_SetPalette, the IDirectDrawPalette_SetEntries
DirectX function is invoked. However, when this happens, a WM_PALETTECHANGED
message is sent to the window.
A WM_PALETTECHANGED message can also be received if the palette is changed for
some other reason, like if the system palette is changed. Therefore, the
palette change handler (DX5_PaletteChanged) has code to deal with this case.
It distinguishes "expected" palette changes (set with SDL_SetPalette) from
"unexpected" palette changes using the colorchange_expected variable, which is
set before calling IDirectDrawPalette_SetEntries. However, the code to set
this variable is missing in the fullscreen code path. By setting this
variable, the palette change is handled properly and the freezes go away.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 13 Apr 2009 00:53:12 +0000 |
parents | a1b03ba2fcd0 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* General quit handling code for SDL */ #ifdef HAVE_SIGNAL_H #include <signal.h> #endif #include "SDL_events.h" #include "SDL_events_c.h" #ifdef HAVE_SIGNAL_H static void SDL_HandleSIG(int sig) { /* Reset the signal handler */ signal(sig, SDL_HandleSIG); /* Signal a quit interrupt */ SDL_PrivateQuit(); } #endif /* HAVE_SIGNAL_H */ /* Public functions */ int SDL_QuitInit(void) { #ifdef HAVE_SIGNAL_H void (*ohandler)(int); /* Both SIGINT and SIGTERM are translated into quit interrupts */ ohandler = signal(SIGINT, SDL_HandleSIG); if ( ohandler != SIG_DFL ) signal(SIGINT, ohandler); ohandler = signal(SIGTERM, SDL_HandleSIG); if ( ohandler != SIG_DFL ) signal(SIGTERM, ohandler); #endif /* HAVE_SIGNAL_H */ /* That's it! */ return(0); } void SDL_QuitQuit(void) { #ifdef HAVE_SIGNAL_H void (*ohandler)(int); ohandler = signal(SIGINT, SIG_DFL); if ( ohandler != SDL_HandleSIG ) signal(SIGINT, ohandler); ohandler = signal(SIGTERM, SIG_DFL); if ( ohandler != SDL_HandleSIG ) signal(SIGTERM, ohandler); #endif /* HAVE_SIGNAL_H */ } /* This function returns 1 if it's okay to close the application window */ int SDL_PrivateQuit(void) { int posted; posted = 0; if ( SDL_ProcessEvents[SDL_QUIT] == SDL_ENABLE ) { SDL_Event event; event.type = SDL_QUIT; if ( (SDL_EventOK == NULL) || (*SDL_EventOK)(&event) ) { posted = 1; SDL_PushEvent(&event); } } return(posted); }