Mercurial > sdl-ios-xcode
view src/video/photon/SDL_ph_video.h @ 4384:6800e2560310 SDL-1.2
Fixed bugs #882 and 865, re-opening bug #634
Ronald Lamprecht to SDL
Hi,
Sam Lantinga wrote:
The problem with that fix is that it breaks IME events again. Maybe
we can handle keyboard events differently to prevent this issue?
Spending an hour reading MSDN, analysing SDL and another hour testing the reality on XP I am really wondering how patch r4990 could have ever worked in any situation. It's main effect is to break the unicode translation and causing spurious activation events!
Why does TranslateMessage(&msg) nothing useful? Simply because it does not affect "msg" at all! All keyboard events are dispatched without the slightest change (see MSDN). TranslateMessage() just appends additional WM_CHAR, WM_DEADCHAR, WM_SYSCHAR, WM_SYSDEADCHAR event messages to the queue. But I could not find any SDL event handling routine that catches these events and transforms them to proper SDL keyevents while eliminating the corresponding WM_KEYDOWN, etc. events. Thus any IME input like the '@' generated by "Alt + 6(Numpad) + 4(Numpad)" is simply lost.
But the situation is even worse! Up to r4990 the TranslateKey()/ToUnicode() calls did evaluate dead keys and did deliver proper key events for subsequent key strokes like '´' + 'e' resulting in 'é'. ToUnicode() needs proper key state informations to be able to handle these substitutions. But unfortunatly TranslateMessage() needs the same state information and eats it up while generating the WM_CHAR messages :-( Thus the current 1.2.14 breakes the partial IME support of previous releases, too.
The key state race condition between ToUnicode() and TranslateMessage() requires to avoid any ToUnicode() usage for receiving proper WM_CHAR, etc. messages generated by TranslateMessage(). (Yes - the '@' and 'é' appear as WM_CHAR messages when unicode is switched off).
The spurious SDL activation events are *not* caused by additional WM_ACTIVATE Windows messages! Besides DIB_HandleMessage() SDL_PrivateAppActive() is called by another source which I am not yet aware of - any hints?
Thus I do strongly recommend the deletion of the TranslateMessage(&msg) call as a quick fix.
A proper support of unicode and IME requires a clean SDL keyboard input concept first. Which SDL keyboards events should be transmitted to the app when the user presses '´' + 'e' ? Within the current unicode handling the first key stroke is hidden. Even though ToUnicode() delivers the proper key SDL does ignore it in TranslateKey(). Just the composed key event is transmitted to the app. That is what you expect for text input, but the app can no longer use keys like '^' as a key button because it will never receive a key event for it!
With a given concept it seems to be necessary to regenerate SDL key events out of the WM_CHAR, etc. events and to drop all related direct WM_KEYDOWN, etc. events while the remaining basic WM_KEYDOWN, etc. events would still have to result in SDL key events.
Anyway the source of the spurious WM_ACTIVATE should be located to avoid future trouble.
Greets,
Ronald
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 17 Nov 2009 04:59:13 +0000 |
parents | a1b03ba2fcd0 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef __SDL_PH_VIDEO_H__ #define __SDL_PH_VIDEO_H__ #include "SDL_mouse.h" #include "../SDL_sysvideo.h" #include <sys/neutrino.h> #include <Ph.h> #include <Pt.h> #include <photon/Pg.h> #include <photon/PdDirect.h> #if SDL_VIDEO_OPENGL #if (_NTO_VERSION < 630) #include <photon/PdGL.h> #else #include <GL/qnxgl.h> #include <GL/GLPh.h> #endif /* 6.3.0 */ #endif /* SDL_VIDEO_OPENGL */ /* Hidden "this" pointer for the video functions */ #define _THIS SDL_VideoDevice* this #define PH_OGL_MAX_ATTRIBS 32 #define SDLPH_PAL_NONE 0x00000000L #define SDLPH_PAL_EMULATE 0x00000001L #define SDLPH_PAL_SYSTEM 0x00000002L typedef struct { unsigned char* Y; unsigned char* V; unsigned char* U; } FRAMEDATA; /* Mask values for SDL_ReallocFormat() */ struct ColourMasks { Uint32 red; Uint32 green; Uint32 blue; Uint32 alpha; Uint32 bpp; }; /* Private display data */ struct SDL_PrivateVideoData { PgDisplaySettings_t mode_settings; PtWidget_t *Window; /* used to handle input events */ PhImage_t *image; /* used to display image */ #if SDL_VIDEO_OPENGL #if (_NTO_VERSION < 630) PdOpenGLContext_t* OGLContext; /* OpenGL context */ void* OGLBuffers; /* OpenGL buffers (unused) */ #else qnxglc_t* OGLContext; /* OpenGL context for the 6.3 */ qnxgl_bufs_t* OGLBuffers; /* OpenGL buffers for the 6.3 */ #endif /* 630 */ Uint32 OGLFlags; /* OpenGL flags */ Uint32 OGLBPP; /* OpenGL bpp */ #endif /* SDL_VIDEO_OPENGL */ PgColor_t savedpal[_Pg_MAX_PALETTE]; PgColor_t syspalph[_Pg_MAX_PALETTE]; struct { PdDirectContext_t* direct_context; PdOffscreenContext_t* offscreen_context; PdOffscreenContext_t* offscreen_backcontext; PhDrawContext_t* oldDC; uint8_t* dc_ptr; unsigned char* CurrentFrameData; unsigned char* FrameData0; unsigned char* FrameData1; Uint32 current; Uint32 flags; } ocimage; PgHWCaps_t graphics_card_caps; /* Graphics card caps at the moment of start */ PgVideoModeInfo_t desktop_mode; /* Current desktop video mode information */ int old_video_mode; /* Stored mode before fullscreen switch */ int old_refresh_rate; /* Stored refresh rate befor fullscreen switch */ int mouse_relative; WMcursor* BlankCursor; uint32_t videomode_emulatemode; Uint32 visualbpp; /* current visual bpp */ Uint32 desktopbpp; /* bpp of desktop at the moment of start */ Uint32 desktoppal; /* palette mode emulation or system */ int currently_fullscreen; int currently_hided; /* 1 - window hided (minimazed), 0 - normal */ int currently_maximized; /* 1 - window hided (minimazed), 0 - normal */ PhEvent_t* event; SDL_Overlay* overlay; }; #define mode_settings (this->hidden->mode_settings) #define window (this->hidden->Window) #define SDL_Image (this->hidden->image) #define OCImage (this->hidden->ocimage) #define old_video_mode (this->hidden->old_video_mode) #define old_refresh_rate (this->hidden->old_refresh_rate) #define graphics_card_caps (this->hidden->graphics_card_caps) #define desktopbpp (this->hidden->desktopbpp) #define visualbpp (this->hidden->visualbpp) #define desktoppal (this->hidden->desktoppal) #define savedpal (this->hidden->savedpal) #define syspalph (this->hidden->syspalph) #define currently_fullscreen (this->hidden->currently_fullscreen) #define currently_hided (this->hidden->currently_hided) #define currently_maximized (this->hidden->currently_maximized) #define phevent (this->hidden->event) #define current_overlay (this->hidden->overlay) #define desktop_mode (this->hidden->desktop_mode) #define mouse_relative (this->hidden->mouse_relative) #define SDL_BlankCursor (this->hidden->BlankCursor) #define videomode_emulatemode (this->hidden->videomode_emulatemode) #if SDL_VIDEO_OPENGL #define oglctx (this->hidden->OGLContext) #define oglbuffers (this->hidden->OGLBuffers) #define oglflags (this->hidden->OGLFlags) #define oglbpp (this->hidden->OGLBPP) #endif /* SDL_VIDEO_OPENGL */ #endif /* __SDL_PH_VIDEO_H__ */