Mercurial > sdl-ios-xcode
view src/cdrom/macos/SDL_syscdrom_c.h @ 4384:6800e2560310 SDL-1.2
Fixed bugs #882 and 865, re-opening bug #634
Ronald Lamprecht to SDL
Hi,
Sam Lantinga wrote:
The problem with that fix is that it breaks IME events again. Maybe
we can handle keyboard events differently to prevent this issue?
Spending an hour reading MSDN, analysing SDL and another hour testing the reality on XP I am really wondering how patch r4990 could have ever worked in any situation. It's main effect is to break the unicode translation and causing spurious activation events!
Why does TranslateMessage(&msg) nothing useful? Simply because it does not affect "msg" at all! All keyboard events are dispatched without the slightest change (see MSDN). TranslateMessage() just appends additional WM_CHAR, WM_DEADCHAR, WM_SYSCHAR, WM_SYSDEADCHAR event messages to the queue. But I could not find any SDL event handling routine that catches these events and transforms them to proper SDL keyevents while eliminating the corresponding WM_KEYDOWN, etc. events. Thus any IME input like the '@' generated by "Alt + 6(Numpad) + 4(Numpad)" is simply lost.
But the situation is even worse! Up to r4990 the TranslateKey()/ToUnicode() calls did evaluate dead keys and did deliver proper key events for subsequent key strokes like '´' + 'e' resulting in 'é'. ToUnicode() needs proper key state informations to be able to handle these substitutions. But unfortunatly TranslateMessage() needs the same state information and eats it up while generating the WM_CHAR messages :-( Thus the current 1.2.14 breakes the partial IME support of previous releases, too.
The key state race condition between ToUnicode() and TranslateMessage() requires to avoid any ToUnicode() usage for receiving proper WM_CHAR, etc. messages generated by TranslateMessage(). (Yes - the '@' and 'é' appear as WM_CHAR messages when unicode is switched off).
The spurious SDL activation events are *not* caused by additional WM_ACTIVATE Windows messages! Besides DIB_HandleMessage() SDL_PrivateAppActive() is called by another source which I am not yet aware of - any hints?
Thus I do strongly recommend the deletion of the TranslateMessage(&msg) call as a quick fix.
A proper support of unicode and IME requires a clean SDL keyboard input concept first. Which SDL keyboards events should be transmitted to the app when the user presses '´' + 'e' ? Within the current unicode handling the first key stroke is hidden. Even though ToUnicode() delivers the proper key SDL does ignore it in TranslateKey(). Just the composed key event is transmitted to the app. That is what you expect for text input, but the app can no longer use keys like '^' as a key button because it will never receive a key event for it!
With a given concept it seems to be necessary to regenerate SDL key events out of the WM_CHAR, etc. events and to drop all related direct WM_KEYDOWN, etc. events while the remaining basic WM_KEYDOWN, etc. events would still have to result in SDL key events.
Anyway the source of the spurious WM_ACTIVATE should be located to avoid future trouble.
Greets,
Ronald
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 17 Nov 2009 04:59:13 +0000 |
parents | a1b03ba2fcd0 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* This is the MacOS specific header for the SDL CD-ROM API Contributed by Matt Slot */ /* AppleCD Control calls */ #define kVerifyTheDisc 5 /* Returns noErr if there is disc inserted */ #define kEjectTheDisc 7 /* Eject disc from drive */ #define kUserEject 80 /* Enable/disable the CD-ROM eject button */ #define kReadTOC 100 /* Extract various TOC information from the disc */ #define kReadQ 101 /* Extract Q subcode info for the current track */ #define kAudioTrackSearch 103 /* Start playback from the indicated position */ #define kAudioPlay 104 /* Start playback from the indicated position */ #define kAudioPause 105 /* Pause/continue the playback */ #define kAudioStop 106 /* Stop playback at the indicated position */ #define kAudioStatus 107 /* Return audio play status */ #define kAudioControl 109 /* Set the output volume for the audio channels */ #define kReadAudioVolume 112 /* Get the output volume for the audio channels */ #define kSetTrackList 122 /* Set the track program for the audio CD to play */ #define kGetTrackList 123 /* Get the track program the audio CD is playing */ #define kGetTrackIndex 124 /* Get the track index the audio CD is playing */ #define kSetPlayMode 125 /* Set the audio tracks play mode */ #define kGetPlayMode 126 /* Get the audio tracks play mode */ /* AppleCD Status calls */ #define kGetDriveType 96 /* Get the type of the physical CD-ROM drive */ #define kWhoIsThere 97 /* Get a bitmap of SCSI IDs the driver controls */ #define kGetBlockSize 98 /* Get current block size of the CD-ROM drive */ /* AppleCD other constants */ #define kBlockPosition 0 /* Position at the specified logical block number */ #define kAbsMSFPosition 1 /* Position at the specified Min/Sec/Frame (in BCD) */ #define kTrackPosition 2 /* Position at the specified track number (in BCD) */ #define kIndexPosition 3 /* Position at the nth track in program (in BCD) */ #define kMutedPlayMode 0 /* Play the audio track with no output */ #define kStereoPlayMode 9 /* Play the audio track in normal stereo */ #define kControlFieldMask 0x0D /* Bits 3,2,0 in the nibble */ #define kDataTrackMask 0x04 /* Indicates Data Track */ #define kGetTrackRange 1 /* Query TOC for track numbers */ #define kGetLeadOutArea 2 /* Query TOC for "Lead Out" end of audio data */ #define kGetTrackEntries 3 /* Query TOC for track starts and data types */ #define kStatusPlaying 0 /* Audio Play operation in progress */ #define kStatusPaused 1 /* CD-ROM device in Hold Track ("Pause") state */ #define kStatusMuted 2 /* MUTING-ON operation in progress */ #define kStatusDone 3 /* Audio Play completed */ #define kStatusError 4 /* Error occurred during audio play operation */ #define kStatusStopped 5 /* Audio play operation not requested */ #define kPlayModeSequential 0 /* Play tracks in order */ #define kPlayModeShuffled 1 /* Play tracks randomly */ #define kPlayModeProgrammed 2 /* Use custom playlist */ /* AppleCD Gestalt selectors */ #define kGestaltAudioCDSelector 'aucd' #define kDriverVersion52 0x00000520 #define kDriverVersion51 0x00000510 #define kDriverVersion50 0x00000500 /* Drive type constants */ #define kDriveAppleCD_SC 1 #define kDriveAppleCD_SCPlus_or_150 2 #define kDriveAppleCD_300_or_300Plus 3 /* Misc constants */ #define kFirstSCSIDevice -33 #define kLastSCSIDevice -40 #if PRAGMA_STRUCT_ALIGN #pragma options align=mac68k #endif /* AppleCD driver parameter block */ typedef struct CDCntrlParam { QElemPtr qLink; short qType; short ioTrap; Ptr ioCmdAddr; IOCompletionUPP ioCompletion; OSErr ioResult; StringPtr ioNamePtr; short ioVRefNum; short ioCRefNum; short csCode; union { long longs[6]; short words[11]; unsigned char bytes[22]; struct { unsigned char status; unsigned char play; unsigned char control; unsigned char minute; unsigned char second; unsigned char frame; } cd; } csParam; } CDCntrlParam, *CDCntrlParamPtr; typedef union CDTrackData { long value; /* Treat as a longword value */ struct { unsigned char reserved : 4; /* Unused by AppleCD driver */ unsigned char control : 4; /* Track flags (data track?) */ unsigned char min; /* Start of track (BCD) */ unsigned char sec; /* Start of track (BCD) */ unsigned char frame; /* Start of track (BCD) */ } entry; /* Broken into fields */ } CDTrackData, *CDTrackPtr; #if PRAGMA_STRUCT_ALIGN #pragma options align=reset #endif