Mercurial > sdl-ios-xcode
view src/video/xbios/SDL_xbios_sb3.h @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 21 Sep 2009 11:14:36 +0000 |
parents | 05c9e942cc46 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* ScreenBlaster 3 definitions Patrice Mandin */ #ifndef _SDL_xbios_sb3_h_ #define _SDL_xbios_sb3_h_ /*--- Defines ---*/ #ifndef C_SCPN #define C_SCPN 0x5343504EL #endif #define SCPN_DEV_1BPP 0 #define SCPN_DEV_2BPP 1 #define SCPN_DEV_4BPP 2 #define SCPN_DEV_8BPP 3 #define SCPN_DEV_16BPP 4 extern const int SDL_XBIOS_scpn_planes_device[]; /*--- Types ---*/ typedef struct { unsigned short virtual_width; /* Virtual screen width */ unsigned short virtual_height; /* Virtual screen height */ unsigned short visible_width; /* Visible width */ unsigned short visible_height; /* Visible height */ unsigned short h_pos; /* Horizontal position in virtual screen */ unsigned short v_pos; /* Vertical position in virtual screen */ unsigned short dummy; unsigned long size; /* Size of screen in bytes */ unsigned short device; /* Device number to find planes = getRez() */ /* = Index in scpn_planes_device[] */ } __attribute__((packed)) scpn_screeninfo_t; typedef struct { unsigned long magic; /* just a BRA assembler jump */ unsigned short version; void *dummy1; unsigned short ptsout0_1; unsigned short ptsout0_2; unsigned short dummy3; unsigned char date[8]; /* Date of program build */ unsigned char asm_string[30]; /* 10 times the 'ASM' string */ unsigned short dummy4; scpn_screeninfo_t *screen_info; unsigned short dummy6; } __attribute__((packed)) scpn_cookie_t; /*--- Function prototypes ---*/ int SDL_XBIOS_SB3Usable(scpn_cookie_t *cookie_scpn); void SDL_XBIOS_ListSB3Modes(_THIS, int actually_add, scpn_cookie_t *cookie_scpn); #endif /* _SDL_xbios_sb3_h_ */