Mercurial > sdl-ios-xcode
view src/video/xbios/SDL_xbios_milan.h @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 21 Sep 2009 11:14:36 +0000 |
parents | 6405314a7c07 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* Milan Xbios video functions Patrice Mandin */ #ifndef _SDL_xbios_milan_h #define _SDL_xbios_milan_h #include "SDL_xbios.h" /*--- Defines ---*/ /* Cookies */ #ifndef C__MIL #define C__MIL 0x5F4D494CL #endif #ifndef C__VDI #define C__VDI 0x5F564449L #endif /* Vsetscreen() parameters */ #define MI_MAGIC 0x4D49 enum { CMD_GETMODE=0, CMD_SETMODE, CMD_GETINFO, CMD_ALLOCPAGE, CMD_FREEPAGE, CMD_FLIPPAGE, CMD_ALLOCMEM, CMD_FREEMEM, CMD_SETADR, CMD_ENUMMODES }; enum { ENUMMODE_EXIT=0, ENUMMODE_CONT }; enum { BLK_ERR=0, BLK_OK, BLK_CLEARED }; /* scrFlags */ #define SCRINFO_OK 1 /* scrClut */ #define NO_CLUT 0 #define HARD_CLUT 1 #define SOFT_CLUT 2 /* scrFormat */ #define INTERLEAVE_PLANES 0 #define STANDARD_PLANES 1 #define PACKEDPIX_PLANES 2 /* bitFlags */ #define STANDARD_BITS 1 #define FALCON_BITS 2 #define INTEL_BITS 8 /*--- Structures ---*/ typedef struct _scrblk { unsigned long size; /* size of strukture */ unsigned long blk_status; /* status bits of blk */ unsigned long blk_start; /* Start Adress */ unsigned long blk_len; /* length of memblk */ unsigned long blk_x; /* x pos in total screen*/ unsigned long blk_y; /* y pos in total screen */ unsigned long blk_w; /* width */ unsigned long blk_h; /* height */ unsigned long blk_wrap; /* width in bytes */ } __attribute__((packed)) SCRMEMBLK; typedef struct screeninfo { unsigned long size; /* Size of structure */ unsigned long devID; /* device id number */ unsigned char name[64]; /* Friendly name of Screen */ unsigned long scrFlags; /* some Flags */ unsigned long frameadr; /* Adress of framebuffer */ unsigned long scrHeight; /* visible X res */ unsigned long scrWidth; /* visible Y res */ unsigned long virtHeight; /* virtual X res */ unsigned long virtWidth; /* virtual Y res */ unsigned long scrPlanes; /* color Planes */ unsigned long scrColors; /* # of colors */ unsigned long lineWrap; /* # of Bytes to next line */ unsigned long planeWarp; /* # of Bytes to next plane */ unsigned long scrFormat; /* screen Format */ unsigned long scrClut; /* type of clut */ unsigned long redBits; /* Mask of Red Bits */ unsigned long greenBits; /* Mask of Green Bits */ unsigned long blueBits; /* Mask of Blue Bits */ unsigned long alphaBits; /* Mask of Alpha Bits */ unsigned long genlockBits;/* Mask of Genlock Bits */ unsigned long unusedBits; /* Mask of unused Bits */ unsigned long bitFlags; /* Bits organisation flags */ unsigned long maxmem; /* max. memory in this mode */ unsigned long pagemem; /* needed memory for one page */ unsigned long max_x; /* max. possible width */ unsigned long max_y; /* max. possible heigth */ } __attribute__((packed)) SCREENINFO; /*--- Functions prototypes ---*/ void SDL_XBIOS_ListMilanModes(_THIS, int actually_add); #endif /* _SDL_xbios_milan_h */