Mercurial > sdl-ios-xcode
view src/video/photon/SDL_ph_video.h @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 21 Sep 2009 11:14:36 +0000 |
parents | a1b03ba2fcd0 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef __SDL_PH_VIDEO_H__ #define __SDL_PH_VIDEO_H__ #include "SDL_mouse.h" #include "../SDL_sysvideo.h" #include <sys/neutrino.h> #include <Ph.h> #include <Pt.h> #include <photon/Pg.h> #include <photon/PdDirect.h> #if SDL_VIDEO_OPENGL #if (_NTO_VERSION < 630) #include <photon/PdGL.h> #else #include <GL/qnxgl.h> #include <GL/GLPh.h> #endif /* 6.3.0 */ #endif /* SDL_VIDEO_OPENGL */ /* Hidden "this" pointer for the video functions */ #define _THIS SDL_VideoDevice* this #define PH_OGL_MAX_ATTRIBS 32 #define SDLPH_PAL_NONE 0x00000000L #define SDLPH_PAL_EMULATE 0x00000001L #define SDLPH_PAL_SYSTEM 0x00000002L typedef struct { unsigned char* Y; unsigned char* V; unsigned char* U; } FRAMEDATA; /* Mask values for SDL_ReallocFormat() */ struct ColourMasks { Uint32 red; Uint32 green; Uint32 blue; Uint32 alpha; Uint32 bpp; }; /* Private display data */ struct SDL_PrivateVideoData { PgDisplaySettings_t mode_settings; PtWidget_t *Window; /* used to handle input events */ PhImage_t *image; /* used to display image */ #if SDL_VIDEO_OPENGL #if (_NTO_VERSION < 630) PdOpenGLContext_t* OGLContext; /* OpenGL context */ void* OGLBuffers; /* OpenGL buffers (unused) */ #else qnxglc_t* OGLContext; /* OpenGL context for the 6.3 */ qnxgl_bufs_t* OGLBuffers; /* OpenGL buffers for the 6.3 */ #endif /* 630 */ Uint32 OGLFlags; /* OpenGL flags */ Uint32 OGLBPP; /* OpenGL bpp */ #endif /* SDL_VIDEO_OPENGL */ PgColor_t savedpal[_Pg_MAX_PALETTE]; PgColor_t syspalph[_Pg_MAX_PALETTE]; struct { PdDirectContext_t* direct_context; PdOffscreenContext_t* offscreen_context; PdOffscreenContext_t* offscreen_backcontext; PhDrawContext_t* oldDC; uint8_t* dc_ptr; unsigned char* CurrentFrameData; unsigned char* FrameData0; unsigned char* FrameData1; Uint32 current; Uint32 flags; } ocimage; PgHWCaps_t graphics_card_caps; /* Graphics card caps at the moment of start */ PgVideoModeInfo_t desktop_mode; /* Current desktop video mode information */ int old_video_mode; /* Stored mode before fullscreen switch */ int old_refresh_rate; /* Stored refresh rate befor fullscreen switch */ int mouse_relative; WMcursor* BlankCursor; uint32_t videomode_emulatemode; Uint32 visualbpp; /* current visual bpp */ Uint32 desktopbpp; /* bpp of desktop at the moment of start */ Uint32 desktoppal; /* palette mode emulation or system */ int currently_fullscreen; int currently_hided; /* 1 - window hided (minimazed), 0 - normal */ int currently_maximized; /* 1 - window hided (minimazed), 0 - normal */ PhEvent_t* event; SDL_Overlay* overlay; }; #define mode_settings (this->hidden->mode_settings) #define window (this->hidden->Window) #define SDL_Image (this->hidden->image) #define OCImage (this->hidden->ocimage) #define old_video_mode (this->hidden->old_video_mode) #define old_refresh_rate (this->hidden->old_refresh_rate) #define graphics_card_caps (this->hidden->graphics_card_caps) #define desktopbpp (this->hidden->desktopbpp) #define visualbpp (this->hidden->visualbpp) #define desktoppal (this->hidden->desktoppal) #define savedpal (this->hidden->savedpal) #define syspalph (this->hidden->syspalph) #define currently_fullscreen (this->hidden->currently_fullscreen) #define currently_hided (this->hidden->currently_hided) #define currently_maximized (this->hidden->currently_maximized) #define phevent (this->hidden->event) #define current_overlay (this->hidden->overlay) #define desktop_mode (this->hidden->desktop_mode) #define mouse_relative (this->hidden->mouse_relative) #define SDL_BlankCursor (this->hidden->BlankCursor) #define videomode_emulatemode (this->hidden->videomode_emulatemode) #if SDL_VIDEO_OPENGL #define oglctx (this->hidden->OGLContext) #define oglbuffers (this->hidden->OGLBuffers) #define oglflags (this->hidden->OGLFlags) #define oglbpp (this->hidden->OGLBPP) #endif /* SDL_VIDEO_OPENGL */ #endif /* __SDL_PH_VIDEO_H__ */