Mercurial > sdl-ios-xcode
view src/video/ataricommon/SDL_atarigl_c.h @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 21 Sep 2009 11:14:36 +0000 |
parents | a1b03ba2fcd0 |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* Atari OSMesa.ldg implementation of SDL OpenGL support */ #ifndef _SDL_ATARIGL_H_ #define _SDL_ATARIGL_H_ #if SDL_VIDEO_OPENGL #include <GL/osmesa.h> #endif #include "../SDL_sysvideo.h" /* Hidden "this" pointer for the video functions */ #define _THIS SDL_VideoDevice *this struct SDL_PrivateGLData { int gl_active; /* to stop switching drivers while we have a valid context */ int gl_oldmesa; /* Old OpenGL support ? */ int gl_pixelsize; /* for CopyShadow functions */ SDL_bool gl_upsidedown; /* Some implementations draw upside down */ Uint8 *gl_shadow; /* Shadow buffer for old implementations */ /* for unsupported OSMesa buffer formats */ void (*ConvertSurface)(_THIS, SDL_Surface *surface); /* to convert the shadow buffer to the screen format */ void (*CopyShadow)(_THIS, SDL_Surface *surface); #if SDL_VIDEO_OPENGL OSMesaContext ctx; /* OpenGL functions */ void (*glGetIntegerv)( GLenum pname, GLint *value ); void (*glFinish)(void); void (*glFlush)(void); /* osmesa.ldg */ OSMesaContext (*OSMesaCreateContextExt)( GLenum format, GLint depthBits, GLint stencilBits, GLint accumBits, OSMesaContext sharelist); void (*OSMesaDestroyContext)( OSMesaContext ctx ); GLboolean (*OSMesaMakeCurrent)( OSMesaContext ctx, void *buffer, GLenum type, GLsizei width, GLsizei height ); void (*OSMesaPixelStore)( GLint pname, GLint value ); void * (*OSMesaGetProcAddress)( const char *funcName ); /* mesa_gl.ldg, tiny_gl.ldg */ void *(*OSMesaCreateLDG)( long format, long type, long width, long height ); void (*OSMesaDestroyLDG)(void); /* Info needed to compare existing context with new asked one */ int width, height; GLenum format; GLint depth,stencil,accum; #endif }; /* Variable names */ #define gl_active (this->gl_data->gl_active) #define gl_ctx (this->gl_data->ctx) #define gl_oldmesa (this->gl_data->gl_oldmesa) #define gl_pixelsize (this->gl_data->gl_pixelsize) #define gl_upsidedown (this->gl_data->gl_upsidedown) #define gl_shadow (this->gl_data->gl_shadow) #define gl_convert (this->gl_data->ConvertSurface) #define gl_copyshadow (this->gl_data->CopyShadow) #define gl_curformat (this->gl_data->format) #define gl_curdepth (this->gl_data->depth) #define gl_curstencil (this->gl_data->stencil) #define gl_curaccum (this->gl_data->accum) #define gl_curwidth (this->gl_data->width) #define gl_curheight (this->gl_data->height) /* OpenGL functions */ extern int SDL_AtariGL_Init(_THIS, SDL_Surface *current); extern void SDL_AtariGL_Quit(_THIS, SDL_bool unload); extern void SDL_AtariGL_InitPointers(_THIS); extern int SDL_AtariGL_LoadLibrary(_THIS, const char *path); extern void *SDL_AtariGL_GetProcAddress(_THIS, const char *proc); extern int SDL_AtariGL_GetAttribute(_THIS, SDL_GLattr attrib, int* value); extern int SDL_AtariGL_MakeCurrent(_THIS); extern void SDL_AtariGL_SwapBuffers(_THIS); #endif /* _SDL_ATARIGL_H_ */