Mercurial > sdl-ios-xcode
view src/video/Xext/extensions/Xv.h @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 21 Sep 2009 11:14:36 +0000 |
parents | eadc0746dfaf |
children | 782fd950bd46 |
line wrap: on
line source
/*********************************************************** Copyright 1991 by Digital Equipment Corporation, Maynard, Massachusetts, and the Massachusetts Institute of Technology, Cambridge, Massachusetts. All Rights Reserved Permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation, and that the names of Digital or MIT not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. DIGITAL DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO EVENT SHALL DIGITAL BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. ******************************************************************/ /* $XFree86: xc/include/extensions/Xv.h,v 1.5 1999/12/11 19:28:48 mvojkovi Exp $ */ #ifndef XV_H #define XV_H /* ** File: ** ** Xv.h --- Xv shared library and server header file ** ** Author: ** ** David Carver (Digital Workstation Engineering/Project Athena) ** ** Revisions: ** ** 05.15.91 Carver ** - version 2.0 upgrade ** ** 01.24.91 Carver ** - version 1.4 upgrade ** */ #include <X11/X.h> #define XvName "XVideo" #define XvVersion 2 #define XvRevision 2 /* Symbols */ typedef XID XvPortID; typedef XID XvEncodingID; #define XvNone 0 #define XvInput 0 #define XvOutput 1 #define XvInputMask (1L<<XvInput) #define XvOutputMask (1L<<XvOutput) #define XvVideoMask 0x00000004 #define XvStillMask 0x00000008 #define XvImageMask 0x00000010 /* These two are not client viewable */ #define XvPixmapMask 0x00010000 #define XvWindowMask 0x00020000 #define XvGettable 0x01 #define XvSettable 0x02 #define XvRGB 0 #define XvYUV 1 #define XvPacked 0 #define XvPlanar 1 #define XvTopToBottom 0 #define XvBottomToTop 1 /* Events */ #define XvVideoNotify 0 #define XvPortNotify 1 #define XvNumEvents 2 /* Video Notify Reasons */ #define XvStarted 0 #define XvStopped 1 #define XvBusy 2 #define XvPreempted 3 #define XvHardError 4 #define XvLastReason 4 #define XvNumReasons (XvLastReason + 1) #define XvStartedMask (1L<<XvStarted) #define XvStoppedMask (1L<<XvStopped) #define XvBusyMask (1L<<XvBusy) #define XvPreemptedMask (1L<<XvPreempted) #define XvHardErrorMask (1L<<XvHardError) #define XvAnyReasonMask ((1L<<XvNumReasons) - 1) #define XvNoReasonMask 0 /* Errors */ #define XvBadPort 0 #define XvBadEncoding 1 #define XvBadControl 2 #define XvNumErrors 3 /* Status */ #define XvBadExtension 1 #define XvAlreadyGrabbed 2 #define XvInvalidTime 3 #define XvBadReply 4 #define XvBadAlloc 5 #endif /* XV_H */