Mercurial > sdl-ios-xcode
view src/timer/mint/SDL_vbltimer.S @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Mon, 21 Sep 2009 11:14:36 +0000 |
| parents | a1b03ba2fcd0 |
| children | 5425a6fbacf8 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ /* * VBL queue routine * * Patrice Mandin */ #define _vbl_queue 0x456 #define _hz_200 0x4ba .text .globl _SDL_AtariVblInstall .globl _SDL_AtariVblUninstall .globl _SDL_MintAudio_hasfpu /*--- Vector installer ---*/ _SDL_AtariVblInstall: movel sp@(4),my_vector lea _my_vbl,a0 clrw vbl_mutex movel _hz_200.w, _SDL_Atari_hz200 /* Stop interrupts */ movew #0x2700,sr /* Read vbl_queue pointer */ movel _vbl_queue.w,a1 /* Search a free place */ moveq #7,d0 bcl_search_place: movel (a1),d1 beqs place_found addql #4,a1 dbra d0,bcl_search_place /* Not found */ moveq #1,d0 bras exit_vbl_queue /* Then install ourselves */ place_found: movel a0,(a1) moveq #0,d0 exit_vbl_queue: /* Restart interrupts */ movew #0x2300,sr rts /*--- Vector uninstaller ---*/ _SDL_AtariVblUninstall: movel sp@(4),d0 cmpl my_vector,d0 bnes badvector movel #_my_vbl,d0 /* Stop interrupts */ movew #0x2700,sr /* Read vbl_queue pointer */ movel _vbl_queue.w,a1 /* Search where we are */ moveq #7,d1 bcl2_search_place: cmpl (a1),d0 bnes next_place clrl (a1) moveq #0,d1 next_place: addql #4,a1 dbra d1,bcl2_search_place /* Restart interrupts */ movew #0x2300,sr badvector: rts /*--- Our vbl ---*/ _my_vbl: /* Update _hz_200 */ movel _hz_200.w, _SDL_Atari_hz200 /* Verify if this is not already running */ tstw vbl_mutex bnes vbl_end notw vbl_mutex moveml d0-d7/a0-a6,sp@- /* Save FPU if needed */ tstw _SDL_MintAudio_hasfpu beqs SDL_AtariVbl_nofpu1 .chip 68060 fsave sp@- fmoveml fpcr/fpsr/fpiar,sp@- fmovemx fp0-fp7,sp@- .chip 68000 SDL_AtariVbl_nofpu1: movel my_vector,a0 jsr a0@ /* Restore FPU if needed */ tstw _SDL_MintAudio_hasfpu beqs SDL_AtariVbl_Xbios_nofpu2 .chip 68060 fmovemx sp@+,fp0-fp7 fmoveml sp@+,fpcr/fpsr/fpiar frestore sp@+ .chip 68000 SDL_AtariVbl_Xbios_nofpu2: moveml sp@+,d0-d7/a0-a6 clrw vbl_mutex vbl_end: rts .data .even .comm _SDL_Atari_hz200,4*1 .even .comm vbl_mutex,2*1 .even .comm my_vector,4*1