Mercurial > sdl-ios-xcode
view src/audio/SDL_mixer_m68k.c @ 4223:63fd67e17705 SDL-1.2
Fixed bug #727
Lorenzo Desole 2009-04-19 07:36:10 PDT
I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.
MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).
The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.
This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]
Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.
I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.
This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:
int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);
I can't rule out possible side effects, but I don't see any.
While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.
Thanks in advance.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 21 Sep 2009 11:14:36 +0000 |
parents | a1b03ba2fcd0 |
children | 124629b76853 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* m68k assembly mix routines Patrice Mandin */ #if defined(__M68000__) && defined(__GNUC__) void SDL_MixAudio_m68k_U8(char* dst, char* src, long len, long volume, char* mix8) { __asm__ __volatile__ ( "tstl %2\n" " beqs stoploop_u8\n" "mixloop_u8:\n" /* Mix a sample */ " moveq #0,%%d0\n" " moveq #0,%%d1\n" " moveb %1@+,%%d0\n" /* d0 = *src++ */ " sub #128,%%d0\n" /* d0 -= 128 */ " muls %3,%%d0\n" /* d0 *= volume (0<=volume<=128) */ " moveb %0@,%%d1\n" /* d1 = *dst */ " asr #7,%%d0\n" /* d0 /= 128 (SDL_MIX_MAXVOLUME) */ " add #128,%%d0\n" /* d0 += 128 */ " add %%d1,%%d0\n" " moveb %4@(%%d0:w),%0@+\n" /* Loop till done */ " subql #1,%2\n" " bhis mixloop_u8\n" "stoploop_u8:\n" : /* no return value */ : /* input */ "a"(dst), "a"(src), "d"(len), "d"(volume), "a"(mix8) : /* clobbered registers */ "d0", "d1", "cc", "memory" ); } void SDL_MixAudio_m68k_S8(char* dst, char* src, long len, long volume) { __asm__ __volatile__ ( "tstl %2\n" " beqs stoploop_s8\n" " moveq #-128,%%d2\n" " moveq #127,%%d3\n" "mixloop_s8:\n" /* Mix a sample */ " moveq #0,%%d0\n" " moveq #0,%%d1\n" " moveb %1@+,%%d0\n" /* d0 = *src++ */ " muls %3,%%d0\n" /* d0 *= volume (0<=volume<=128) */ " moveb %0@,%%d1\n" /* d1 = *dst */ " asr #7,%%d0\n" /* d0 /= 128 (SDL_MIX_MAXVOLUME) */ " add %%d1,%%d0\n" " cmp %%d2,%%d0\n" " bges lower_limit_s8\n" " move %%d2,%%d0\n" "lower_limit_s8:\n" " cmp %%d3,%%d0\n" " bles upper_limit_s8\n" " move %%d3,%%d0\n" "upper_limit_s8:\n" " moveb %%d0,%0@+\n" /* Loop till done */ " subql #1,%2\n" " bhis mixloop_s8\n" "stoploop_s8:\n" : /* no return value */ : /* input */ "a"(dst), "a"(src), "d"(len), "d"(volume) : /* clobbered registers */ "d0", "d1", "d2", "d3", "cc", "memory" ); } void SDL_MixAudio_m68k_S16MSB(short* dst, short* src, long len, long volume) { __asm__ __volatile__ ( "tstl %2\n" " beqs stoploop_s16msb\n" " movel #-32768,%%d2\n" " movel #32767,%%d3\n" " lsrl #1,%2\n" "mixloop_s16msb:\n" /* Mix a sample */ " move %1@+,%%d0\n" /* d0 = *src++ */ " muls %3,%%d0\n" /* d0 *= volume (0<=volume<=128) */ " move %0@,%%d1\n" /* d1 = *dst */ " extl %%d1\n" /* extend d1 to 32 bits */ " asrl #7,%%d0\n" /* d0 /= 128 (SDL_MIX_MAXVOLUME) */ " addl %%d1,%%d0\n" " cmpl %%d2,%%d0\n" " bges lower_limit_s16msb\n" " move %%d2,%%d0\n" "lower_limit_s16msb:\n" " cmpl %%d3,%%d0\n" " bles upper_limit_s16msb\n" " move %%d3,%%d0\n" "upper_limit_s16msb:\n" " move %%d0,%0@+\n" /* Loop till done */ " subql #1,%2\n" " bhis mixloop_s16msb\n" "stoploop_s16msb:\n" : /* no return value */ : /* input */ "a"(dst), "a"(src), "d"(len), "d"(volume) : /* clobbered registers */ "d0", "d1", "d2", "d3", "cc", "memory" ); } void SDL_MixAudio_m68k_S16LSB(short* dst, short* src, long len, long volume) { __asm__ __volatile__ ( "tstl %2\n" " beqs stoploop_s16lsb\n" " movel #-32768,%%d2\n" " movel #32767,%%d3\n" " lsrl #1,%2\n" "mixloop_s16lsb:\n" /* Mix a sample */ " move %1@+,%%d0\n" /* d0 = *src++ */ " rorw #8,%%d0\n" " muls %3,%%d0\n" /* d0 *= volume (0<=volume<=128) */ " move %0@,%%d1\n" /* d1 = *dst */ " rorw #8,%%d1\n" " extl %%d1\n" /* extend d1 to 32 bits */ " asrl #7,%%d0\n" /* d0 /= 128 (SDL_MIX_MAXVOLUME) */ " addl %%d1,%%d0\n" " cmpl %%d2,%%d0\n" " bges lower_limit_s16lsb\n" " move %%d2,%%d0\n" "lower_limit_s16lsb:\n" " cmpl %%d3,%%d0\n" " bles upper_limit_s16lsb\n" " move %%d3,%%d0\n" "upper_limit_s16lsb:\n" " rorw #8,%%d0\n" " move %%d0,%0@+\n" /* Loop till done */ " subql #1,%2\n" " bhis mixloop_s16lsb\n" "stoploop_s16lsb:\n" : /* no return value */ : /* input */ "a"(dst), "a"(src), "d"(len), "d"(volume) : /* clobbered registers */ "d0", "d1", "d2", "d3", "cc", "memory" ); } #endif