view src/main/beos/SDL_BeApp.cc @ 1748:5e86e34453d4

------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] ------- Created an attachment (id=106) [edit] Patch for src/joystick/win32/SDL_mmjoystick.c I am not even a Windows user, so take the following with a grain of salt: SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick name by looking at the registry. The way it does that seems very fishy to me. Namely, it uses the parameter "index" to construct a registry value name (BTW, those variables used in the code are really badly named). The value of "index" in turn equals the current value of "numdevs", as called from SDL_SYS_JoystickInit. I read through the MSDN docs at <http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>, and I believe the simple fix is to replace line 183 of said file SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey); by the following: SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i], joycaps.szRegKey); However, that is only *hiding* the real issue. Problem is, the list of joysticks as returned by windows may contains "gaps", and the code deals incorrectly with that. Namely those gaps occur if joysticks are removed/(re)added, as the reporter observed. The attached patch fixes this and another (off-by-one) issue in the code. But since I have no Windows machine, I can't even test-compile it, so use with caution.
author Sam Lantinga <slouken@libsdl.org>
date Sat, 29 Apr 2006 20:22:31 +0000
parents 376665398b25
children 782fd950bd46 c121d94672cb a1b03ba2fcd0
line wrap: on
line source

/*
    SDL - Simple DirectMedia Layer
    Copyright (C) 1997-2006 Sam Lantinga

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
    version 2.1 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public
    License along with this library; if not, write to the Free Software
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA

    Sam Lantinga
    slouken@libsdl.org
*/
#include "SDL_config.h"

/* Handle the BeApp specific portions of the application */

#include <AppKit.h>
#include <storage/Path.h>
#include <storage/Entry.h>
#include <unistd.h>

#include "SDL_BeApp.h"
#include "SDL_thread.h"
#include "SDL_timer.h"
#include "SDL_error.h"

/* Flag to tell whether or not the Be application is active or not */
int SDL_BeAppActive = 0;
static SDL_Thread *SDL_AppThread = NULL;

static int StartBeApp(void *unused)
{
	BApplication *App;

	App = new BApplication("application/x-SDL-executable");

	App->Run();
	delete App;
	return(0);
}

/* Initialize the Be Application, if it's not already started */
int SDL_InitBeApp(void)
{
	/* Create the BApplication that handles appserver interaction */
	if ( SDL_BeAppActive <= 0 ) {
		SDL_AppThread = SDL_CreateThread(StartBeApp, NULL);
		if ( SDL_AppThread == NULL ) {
			SDL_SetError("Couldn't create BApplication thread");
			return(-1);
		}
		
		/* Change working to directory to that of executable */
		app_info info;
		if (B_OK == be_app->GetAppInfo(&info)) {
			entry_ref ref = info.ref;
			BEntry entry;
			if (B_OK == entry.SetTo(&ref)) {
				BPath path;
				if (B_OK == path.SetTo(&entry)) {
					if (B_OK == path.GetParent(&path)) {
						chdir(path.Path());
					}
				}
			}
		}	
		
		do {
			SDL_Delay(10);
		} while ( (be_app == NULL) || be_app->IsLaunching() );

		/* Mark the application active */
		SDL_BeAppActive = 0;
	}

	/* Increment the application reference count */
	++SDL_BeAppActive;

	/* The app is running, and we're ready to go */
	return(0);
}

/* Quit the Be Application, if there's nothing left to do */
void SDL_QuitBeApp(void)
{
	/* Decrement the application reference count */
	--SDL_BeAppActive;

	/* If the reference count reached zero, clean up the app */
	if ( SDL_BeAppActive == 0 ) {
		if ( SDL_AppThread != NULL ) {
			if ( be_app != NULL ) { /* Not tested */
				be_app->PostMessage(B_QUIT_REQUESTED);
			}
			SDL_WaitThread(SDL_AppThread, NULL);
			SDL_AppThread = NULL;
		}
		/* be_app should now be NULL since be_app has quit */
	}
}