Mercurial > sdl-ios-xcode
view README.MacOS @ 1748:5e86e34453d4
------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------
Created an attachment (id=106) [edit]
Patch for src/joystick/win32/SDL_mmjoystick.c
I am not even a Windows user, so take the following with a grain of salt:
SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick
name by looking at the registry. The way it does that seems very fishy to me.
Namely, it uses the parameter "index" to construct a registry value name (BTW,
those variables used in the code are really badly named). The value of "index"
in turn equals the current value of "numdevs", as called from
SDL_SYS_JoystickInit.
I read through the MSDN docs at
<http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>,
and I believe the simple fix is to replace line 183 of said file
SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey);
by the following:
SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i],
joycaps.szRegKey);
However, that is only *hiding* the real issue. Problem is, the list of
joysticks as returned by windows may contains "gaps", and the code deals
incorrectly with that. Namely those gaps occur if joysticks are
removed/(re)added, as the reporter observed.
The attached patch fixes this and another (off-by-one) issue in the code. But
since I have no Windows machine, I can't even test-compile it, so use with
caution.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sat, 29 Apr 2006 20:22:31 +0000 |
parents | 37e3ca9254c7 |
children |
line wrap: on
line source
============================================================================== Using the Simple DirectMedia Layer with MacOS 7,8,9 on PPC ============================================================================== These instructions are for people using the Apple MPW environment: http://developer.apple.com/tools/mpw-tools/ CodeWarrior projects are available in the CWprojects directory. ============================================================================== I. Building the Simple DirectMedia Layer libraries: (This step isn't necessary if you have the SDL binary distribution) First, unpack the MPWmake.sea.hqx archive and move SDL.make into the SDL directory. Start MPW Set the current directory within MPW to the SDL toplevel directory. Build "SDL" (Type Command-B and enter "SDL" in the dialog) If everything compiles successfully, you now have the PPC libraries "SDL" and "SDLmain.o" in the 'lib' subdirectory. ============================================================================== II. Building the Simple DirectMedia Layer test programs: First, unpack the MPWmake.sea.hqx archive, move the new rsrc directory to the main SDL directory, and move the makefiles in the new test subdirectory to the SDL 'test' subdirectory. Start MPW Set the current directory within MPW to the SDL 'test' subdirectory. Build the programs that have an associated MPW makefile (file ending with .make), including "testwin", "testalpha", and "graywin". Copy the SDL library file into the test directory, and run! ============================================================================== III. Building the Simple DirectMedia Layer demo programs: Copy one of the test program Makefiles to the demo directory and modify it to match the sources in the demo. ============================================================================== IV. Enjoy! :) If you have a project you'd like me to know about, or want to ask questions, go ahead and join the SDL developer's mailing list by sending e-mail to: sdl-request@libsdl.org and put "subscribe" into the subject of the message. Or alternatively you can use the web interface: http://www.libsdl.org/mailman/listinfo/sdl ==============================================================================