Mercurial > sdl-ios-xcode
view README.AmigaOS @ 1748:5e86e34453d4
------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------
Created an attachment (id=106) [edit]
Patch for src/joystick/win32/SDL_mmjoystick.c
I am not even a Windows user, so take the following with a grain of salt:
SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick
name by looking at the registry. The way it does that seems very fishy to me.
Namely, it uses the parameter "index" to construct a registry value name (BTW,
those variables used in the code are really badly named). The value of "index"
in turn equals the current value of "numdevs", as called from
SDL_SYS_JoystickInit.
I read through the MSDN docs at
<http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>,
and I believe the simple fix is to replace line 183 of said file
SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey);
by the following:
SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i],
joycaps.szRegKey);
However, that is only *hiding* the real issue. Problem is, the list of
joysticks as returned by windows may contains "gaps", and the code deals
incorrectly with that. Namely those gaps occur if joysticks are
removed/(re)added, as the reporter observed.
The attached patch fixes this and another (off-by-one) issue in the code. But
since I have no Windows machine, I can't even test-compile it, so use with
caution.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sat, 29 Apr 2006 20:22:31 +0000 |
parents | 75a95f82bc1f |
children | 6d2e1961661a |
line wrap: on
line source
This is the porting of 1.2.0 version of SDL (the latest stable one) to AmigaOS/68k. All the bugs known of the past version have been corrected. And I've added all the new SDL features. This version of SDL needs Cybergraphx V3 (r69+) or CyberGraphX V4 and AHI v3+. Probably it works also with P96 or CGXAga, but it's untested. This version is available as linked library for SAS/C and GCC, only 68k this time, a powerup (ppcemu compatible) and a morphos version will be ready quite soon (i hope). Implemented: - 8/16/24/32bit video modes, both fullscreen and windowed. - Hardware surfaces. - CGX blitting acceleration. - CGX colorkey blitting acceleration. - AHI audio (8/16 bit, with any audio format), always uses unit 0 for now. - Thread support (maybe not 100% compatible with other implementations) - Semaphores - Window resizing and backdrop windows (NEW) - Joystick/Joypad support. To do: - CDRom audio playing support - OpenGL (A guy was working on it but I've lost his tracks :( ) The SAS/C library is distributed with debug info attached, to strip debug info simply add STRIPDEBUG argument to the linker. NOTE: SDL includes debug output using kprintf, to disable it add to your project a function like this: void kprintf(char *a,...) { } Otherwise you can redirect the debug to a console window with sushi, sashimi or similar tools (the default output is the internal serial port). For info, support, bugfix and other feel free to mail me: Gabriele Greco (gabriele.greco@aruba.it) You can find also a small SDL Amiga page at: http://ggreco.interfree.it/sdl.html