To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Fri, 18 Nov 2005 23:39:02 +0100 Subject: [SDL] Mouse position bugs on Mac OS X The attached patch fixes a few bugs in SDL related to the mouse position in windowed mode on Mac OS X, reproduced using the attached minimal test program - at least here on 10.3.9, with SDL CVS from today. Could anyone test whether the bugs exist and are fixed by the patch on 10.2 and 10.4? 1. When using OpenGL, the vertical mouse positions obtained through events or SDL_GetMouseState() are off by one. 2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate. 3. Clicks on the topmost pixel row of the window are not recognized. 1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only occur in windowed mode, not in fullscreen. The cause for 1 and 3 is that in Cocoa, "the location of the mouse" seems to be defined as "the location of the top left corner of the mouse pointer's hot pixel" (this is not documented, it's just what I found out here), which together with the fact that Cocoa's usual y coordinates start at the bottom and increase upwards means that the y coordinate of the mouse runs from 1 to h, not from 0 to h-1, in a window of height h. If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9), can this be applied to the CVS? -Christian To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Mon, 28 Nov 2005 10:41:51 +0100 Subject: [SDL] Re: Mouse position bugs on Mac OS X I wrote: > I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9 So, here are the results of my tests (with patched and unpatched frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9): On 10.1.5, my test program doesn't run because of "Undefined symbols: SDL undefined reference to _CGMainDisplayID expected to be defined in Carbon". I guess not supporting 10.1 was a deliberate decision then and that's OK with me. On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my original post and are fixed by my patch. That is, there is no difference between pre/post 10.3 and the patched version works correctly in all combinations of GL/non-GL and windowed/fullscreen. I therefore recommend the patch for inclusion. -Christian

These are test programs for the SDL library:

	testver		Check the version and dynamic loading and endianness
	testtypes	Check to see if the data types are the correct size
	testhread	Hacked up test of multi-threading
	testlock	Hacked up test of multi-threading and locking
	testerror	Tests multi-threaded error handling
	testsem		Tests SDL's semaphore implementation
	testtimer	Test the timer facilities
	loopwave	Audio test -- loop playing a WAV file
	testcdrom	Sample audio CD control program
	testkeys	List the available keyboard keys
	testvidinfo	Show the pixel format of the display and perfom the benchmark
	checkkeys	Watch the key events to check the keyboard
	testwin		Display a BMP image at various depths
	graywin		Display a gray gradient and center mouse on spacebar
	testsprite	Example of fast sprite movement on the screen
	testbitmap	Test displaying 1-bit bitmaps
	testalpha	Display an alpha faded icon -- paint with mouse
	testwm		Test window manager -- title, icon, events
	threadwin	Test multi-threaded event handling
	testgl		A very simple example of using OpenGL with SDL
	testjoystick	List joysticks and watch joystick events
	testoverlay	Tests the software/hardware overlay functionality.
	testoverlay2	Tests the overlay flickering/scaling during playback.
	testblitspeed	Tests performance of SDL's blitters and converters.