Mercurial > sdl-ios-xcode
view src/video/ps2gs/SDL_gsvideo.h @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | e8157fcb3114 |
| children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997, 1998, 1999, 2000 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif #ifndef _SDL_gsvideo_h #define _SDL_gsvideo_h #include <sys/types.h> #include <termios.h> #include <linux/ps2/dev.h> #include <linux/ps2/gs.h> #include "SDL_mouse.h" #include "SDL_mutex.h" #include "SDL_sysvideo.h" /* Hidden "this" pointer for the video functions */ #define _THIS SDL_VideoDevice *this /* Private display data */ struct SDL_PrivateVideoData { /* Gotta love that simple PS2 graphics interface. :) */ int console_fd; int memory_fd; struct ps2_screeninfo saved_vinfo; /* Ye olde linux keyboard code */ int current_vt; int saved_vt; int keyboard_fd; int saved_kbd_mode; struct termios saved_kbd_termios; /* Ye olde linux mouse code */ int mouse_fd; int cursor_drawn; /* The memory mapped DMA area and associated variables */ caddr_t mapped_mem; int pixels_len; int mapped_len; struct ps2_image screen_image; int screen_image_size; unsigned long long *head_tags_mem; unsigned long long *image_tags_mem; unsigned long long *tex_tags_mem; unsigned long long *scale_tags_mem; int dma_pending; }; /* Old variable names */ #define console_fd (this->hidden->console_fd) #define memory_fd (this->hidden->memory_fd) #define saved_vinfo (this->hidden->saved_vinfo) #define current_vt (this->hidden->current_vt) #define saved_vt (this->hidden->saved_vt) #define keyboard_fd (this->hidden->keyboard_fd) #define saved_kbd_mode (this->hidden->saved_kbd_mode) #define saved_kbd_termios (this->hidden->saved_kbd_termios) #define mouse_fd (this->hidden->mouse_fd) #define cursor_drawn (this->hidden->cursor_drawn) #define mapped_mem (this->hidden->mapped_mem) #define pixels_len (this->hidden->pixels_len) #define mapped_len (this->hidden->mapped_len) #define screen_image (this->hidden->screen_image) #define screen_image_size (this->hidden->screen_image_size) #define head_tags_mem (this->hidden->head_tags_mem) #define image_tags_mem (this->hidden->image_tags_mem) #define tex_tags_mem (this->hidden->tex_tags_mem) #define scale_tags_mem (this->hidden->scale_tags_mem) #define dma_pending (this->hidden->dma_pending) /* Shared between the mouse and video code for screen update scaling */ extern int scaleimage_nonblock(int fd, unsigned long long *tm, unsigned long long *sm); #endif /* _SDL_gsvideo_h */