view src/video/ataricommon/SDL_atarigl_c.h @ 1192:54aa9aa32327

To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Fri, 18 Nov 2005 23:39:02 +0100 Subject: [SDL] Mouse position bugs on Mac OS X The attached patch fixes a few bugs in SDL related to the mouse position in windowed mode on Mac OS X, reproduced using the attached minimal test program - at least here on 10.3.9, with SDL CVS from today. Could anyone test whether the bugs exist and are fixed by the patch on 10.2 and 10.4? 1. When using OpenGL, the vertical mouse positions obtained through events or SDL_GetMouseState() are off by one. 2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate. 3. Clicks on the topmost pixel row of the window are not recognized. 1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only occur in windowed mode, not in fullscreen. The cause for 1 and 3 is that in Cocoa, "the location of the mouse" seems to be defined as "the location of the top left corner of the mouse pointer's hot pixel" (this is not documented, it's just what I found out here), which together with the fact that Cocoa's usual y coordinates start at the bottom and increase upwards means that the y coordinate of the mouse runs from 1 to h, not from 0 to h-1, in a window of height h. If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9), can this be applied to the CVS? -Christian To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Mon, 28 Nov 2005 10:41:51 +0100 Subject: [SDL] Re: Mouse position bugs on Mac OS X I wrote: > I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9 So, here are the results of my tests (with patched and unpatched frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9): On 10.1.5, my test program doesn't run because of "Undefined symbols: SDL undefined reference to _CGMainDisplayID expected to be defined in Carbon". I guess not supporting 10.1 was a deliberate decision then and that's OK with me. On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my original post and are fixed by my patch. That is, there is no difference between pre/post 10.3 and the patched version works correctly in all combinations of GL/non-GL and windowed/fullscreen. I therefore recommend the patch for inclusion. -Christian
author Ryan C. Gordon <icculus@icculus.org>
date Mon, 28 Nov 2005 13:58:26 +0000
parents 2ab1cb02a44e
children 19418e4422cb
line wrap: on
line source

/*
    SDL - Simple DirectMedia Layer
    Copyright (C) 1997-2004 Sam Lantinga

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
    License as published by the Free Software Foundation; either
    version 2 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Library General Public License for more details.

    You should have received a copy of the GNU Library General Public
    License along with this library; if not, write to the Free
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

    Sam Lantinga
    slouken@libsdl.org
*/

/* Atari OSMesa.ldg implementation of SDL OpenGL support */

#ifndef _SDL_ATARIGL_H_
#define _SDL_ATARIGL_H_

#ifdef HAVE_OPENGL
#include <GL/osmesa.h>
#endif

#include "SDL_sysvideo.h"
#define _THIS   SDL_VideoDevice *this

struct SDL_PrivateGLData {

    int gl_active; 	/* to stop switching drivers while we have a valid context */
	
	int gl_oldmesa;	/* Old OpenGL support ? */

	int	gl_pixelsize;	/* for CopyShadow functions */

	SDL_bool gl_upsidedown; /* Some implementations draw upside down */

	Uint8 *gl_shadow;	/* Shadow buffer for old implementations */

	/* for unsupported OSMesa buffer formats */
	void (*ConvertSurface)(_THIS, SDL_Surface *surface);	

	/* to convert the shadow buffer to the screen format */
	void (*CopyShadow)(_THIS, SDL_Surface *surface);	

#ifdef HAVE_OPENGL
	OSMesaContext	ctx;

	/* OpenGL functions */
	void (*glGetIntegerv)( GLenum pname, GLint *value );
	void (*glFinish)(void);
	void (*glFlush)(void);

	/* osmesa.ldg */
	OSMesaContext (*OSMesaCreateContextExt)( GLenum format, GLint depthBits, GLint stencilBits, GLint accumBits, OSMesaContext sharelist);
	void (*OSMesaDestroyContext)( OSMesaContext ctx );
	GLboolean (*OSMesaMakeCurrent)( OSMesaContext ctx, void *buffer, GLenum type, GLsizei width, GLsizei height );
	void (*OSMesaPixelStore)( GLint pname, GLint value );
	void * (*OSMesaGetProcAddress)( const char *funcName );

	/* mesa_gl.ldg, tiny_gl.ldg */
	void *(*OSMesaCreateLDG)( long format, long type, long width, long height );
	void (*OSMesaDestroyLDG)(void);

	/* Info needed to compare existing context with new asked one */
	int width, height;
	GLenum format;
	GLint depth,stencil,accum;
#endif
};

/* Variable names */
#define gl_active		(this->gl_data->gl_active)
#define gl_ctx			(this->gl_data->ctx)
#define gl_oldmesa		(this->gl_data->gl_oldmesa)
#define gl_pixelsize	(this->gl_data->gl_pixelsize)
#define gl_upsidedown	(this->gl_data->gl_upsidedown)
#define gl_shadow		(this->gl_data->gl_shadow)
#define gl_convert		(this->gl_data->ConvertSurface)
#define gl_copyshadow	(this->gl_data->CopyShadow)
#define gl_curformat	(this->gl_data->format)
#define gl_curdepth		(this->gl_data->depth)
#define gl_curstencil	(this->gl_data->stencil)
#define gl_curaccum		(this->gl_data->accum)
#define gl_curwidth		(this->gl_data->width)
#define gl_curheight	(this->gl_data->height)

/* OpenGL functions */
extern int SDL_AtariGL_Init(_THIS, SDL_Surface *current);
extern void SDL_AtariGL_Quit(_THIS, SDL_bool unload);
extern void SDL_AtariGL_InitPointers(_THIS);

extern int SDL_AtariGL_LoadLibrary(_THIS, const char *path);
extern void *SDL_AtariGL_GetProcAddress(_THIS, const char *proc);
extern int SDL_AtariGL_GetAttribute(_THIS, SDL_GLattr attrib, int* value);
extern int SDL_AtariGL_MakeCurrent(_THIS);
extern void SDL_AtariGL_SwapBuffers(_THIS);

#endif /* _SDL_ATARIGL_H_ */