Mercurial > sdl-ios-xcode
view src/video/Xext/extensions/xf86dga1.h @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Mon, 28 Nov 2005 13:58:26 +0000 |
parents | 585a7e1285ae |
children | 782fd950bd46 c121d94672cb |
line wrap: on
line source
/* $XFree86: xc/include/extensions/xf86dga1.h,v 1.2 1999/04/17 07:05:41 dawes Exp $ */ /* Copyright (c) 1995 Jon Tombs Copyright (c) 1995 XFree86 Inc */ /************************************************************************ THIS IS THE OLD DGA API AND IS OBSOLETE. PLEASE DO NOT USE IT ANYMORE ************************************************************************/ #ifndef _XF86DGA1_H_ #define _XF86DGA1_H_ #include <X11/Xfuncproto.h> #include "SDL_name.h" #define X_XF86DGAQueryVersion 0 #define X_XF86DGAGetVideoLL 1 #define X_XF86DGADirectVideo 2 #define X_XF86DGAGetViewPortSize 3 #define X_XF86DGASetViewPort 4 #define X_XF86DGAGetVidPage 5 #define X_XF86DGASetVidPage 6 #define X_XF86DGAInstallColormap 7 #define X_XF86DGAQueryDirectVideo 8 #define X_XF86DGAViewPortChanged 9 #define XF86DGADirectPresent 0x0001 #define XF86DGADirectGraphics 0x0002 #define XF86DGADirectMouse 0x0004 #define XF86DGADirectKeyb 0x0008 #define XF86DGAHasColormap 0x0100 #define XF86DGADirectColormap 0x0200 #ifndef _XF86DGA_SERVER_ _XFUNCPROTOBEGIN Bool SDL_NAME(XF86DGAQueryVersion)( #if NeedFunctionPrototypes Display* /* dpy */, int* /* majorVersion */, int* /* minorVersion */ #endif ); Bool SDL_NAME(XF86DGAQueryExtension)( #if NeedFunctionPrototypes Display* /* dpy */, int* /* event_base */, int* /* error_base */ #endif ); Status SDL_NAME(XF86DGAGetVideoLL)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int * /* base addr */, int * /* width */, int * /* bank_size */, int * /* ram_size */ #endif ); Status SDL_NAME(XF86DGAGetVideo)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, char ** /* base addr */, int * /* width */, int * /* bank_size */, int * /* ram_size */ #endif ); Status SDL_NAME(XF86DGADirectVideo)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int /* enable */ #endif ); Status SDL_NAME(XF86DGADirectVideoLL)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int /* enable */ #endif ); Status SDL_NAME(XF86DGAGetViewPortSize)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int * /* width */, int * /* height */ #endif ); Status SDL_NAME(XF86DGASetViewPort)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int x /* X */, int y /* Y */ #endif ); Status SDL_NAME(XF86DGAGetVidPage)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int * /* vid page */ #endif ); Status SDL_NAME(XF86DGASetVidPage)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int /* vid page */ #endif ); Status SDL_NAME(XF86DGAInstallColormap)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, Colormap /*Colormap */ #endif ); int SDL_NAME(XF86DGAForkApp)( #if NeedFunctionPrototypes int screen #endif ); Status SDL_NAME(XF86DGAQueryDirectVideo)( #if NeedFunctionPrototypes Display * /* dpy */, int /* screen */, int * /* flags */ #endif ); Bool SDL_NAME(XF86DGAViewPortChanged)( #if NeedFunctionPrototypes Display * /* dpy */, int /* screen */, int /* n */ #endif ); _XFUNCPROTOEND #endif /* _XF86DGA_SERVER_ */ #endif /* _XF86DGA1_H_ */