view src/joystick/beos/SDL_bejoystick.cc @ 1192:54aa9aa32327

To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Fri, 18 Nov 2005 23:39:02 +0100 Subject: [SDL] Mouse position bugs on Mac OS X The attached patch fixes a few bugs in SDL related to the mouse position in windowed mode on Mac OS X, reproduced using the attached minimal test program - at least here on 10.3.9, with SDL CVS from today. Could anyone test whether the bugs exist and are fixed by the patch on 10.2 and 10.4? 1. When using OpenGL, the vertical mouse positions obtained through events or SDL_GetMouseState() are off by one. 2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate. 3. Clicks on the topmost pixel row of the window are not recognized. 1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only occur in windowed mode, not in fullscreen. The cause for 1 and 3 is that in Cocoa, "the location of the mouse" seems to be defined as "the location of the top left corner of the mouse pointer's hot pixel" (this is not documented, it's just what I found out here), which together with the fact that Cocoa's usual y coordinates start at the bottom and increase upwards means that the y coordinate of the mouse runs from 1 to h, not from 0 to h-1, in a window of height h. If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9), can this be applied to the CVS? -Christian To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Mon, 28 Nov 2005 10:41:51 +0100 Subject: [SDL] Re: Mouse position bugs on Mac OS X I wrote: > I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9 So, here are the results of my tests (with patched and unpatched frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9): On 10.1.5, my test program doesn't run because of "Undefined symbols: SDL undefined reference to _CGMainDisplayID expected to be defined in Carbon". I guess not supporting 10.1 was a deliberate decision then and that's OK with me. On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my original post and are fixed by my patch. That is, there is no difference between pre/post 10.3 and the patched version works correctly in all combinations of GL/non-GL and windowed/fullscreen. I therefore recommend the patch for inclusion. -Christian
author Ryan C. Gordon <icculus@icculus.org>
date Mon, 28 Nov 2005 13:58:26 +0000
parents b8d311d90021
children c9b51268668f
line wrap: on
line source

/*
    SDL - Simple DirectMedia Layer
    Copyright (C) 1997-2004 Sam Lantinga

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
    License as published by the Free Software Foundation; either
    version 2 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Library General Public License for more details.

    You should have received a copy of the GNU Library General Public
    License along with this library; if not, write to the Free
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

    Sam Lantinga
    slouken@libsdl.org
*/

#ifdef SAVE_RCSID
static char rcsid =
 "@(#) $Id$";
#endif

/* This is the system specific header for the SDL joystick API */

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#include <be/support/String.h>
#include <be/device/Joystick.h>

extern "C" {

#include "SDL_error.h"
#include "SDL_joystick.h"
#include "SDL_sysjoystick.h"
#include "SDL_joystick_c.h"


/* The maximum number of joysticks we'll detect */
#define MAX_JOYSTICKS	16	

/* A list of available joysticks */
static char *SDL_joyport[MAX_JOYSTICKS];
static char *SDL_joyname[MAX_JOYSTICKS];

/* The private structure used to keep track of a joystick */
struct joystick_hwdata {
	BJoystick *stick;
	uint8 *new_hats;
	int16 *new_axes;
};

/* Function to scan the system for joysticks.
 * This function should set SDL_numjoysticks to the number of available
 * joysticks.  Joystick 0 should be the system default joystick.
 * It should return 0, or -1 on an unrecoverable fatal error.
 */
int SDL_SYS_JoystickInit(void)
{
	BJoystick joystick;
	int numjoysticks;
	int i;
	int32 nports;
	char name[B_OS_NAME_LENGTH];
	
	/* Search for attached joysticks */
	nports = joystick.CountDevices();
	numjoysticks = 0;
	memset(SDL_joyport, 0, (sizeof SDL_joyport));
	memset(SDL_joyname, 0, (sizeof SDL_joyname));
	for ( i=0; (SDL_numjoysticks < MAX_JOYSTICKS) && (i < nports); ++i ) {
		if ( joystick.GetDeviceName(i, name) == B_OK ) {
			if ( joystick.Open(name) != B_ERROR ) {
				BString stick_name;
				joystick.GetControllerName(&stick_name);
				SDL_joyport[numjoysticks] = strdup(name);
				SDL_joyname[numjoysticks] =
					           strdup(stick_name.String());
				numjoysticks++;
				joystick.Close();
			}
		}
	}
	return(numjoysticks);
}

/* Function to get the device-dependent name of a joystick */
const char *SDL_SYS_JoystickName(int index)
{
	return SDL_joyname[index];
}

/* Function to open a joystick for use.
   The joystick to open is specified by the index field of the joystick.
   This should fill the nbuttons and naxes fields of the joystick structure.
   It returns 0, or -1 if there is an error.
 */
int SDL_SYS_JoystickOpen(SDL_Joystick *joystick)
{
	BJoystick *stick;

	/* Create the joystick data structure */
	joystick->hwdata = (struct joystick_hwdata *)
	                   malloc(sizeof(*joystick->hwdata));
	if ( joystick->hwdata == NULL ) {
		SDL_OutOfMemory();
		return(-1);
	}
	memset(joystick->hwdata, 0, sizeof(*joystick->hwdata));
	stick = new BJoystick;
	joystick->hwdata->stick = stick;

	/* Open the requested joystick for use */
	if ( stick->Open(SDL_joyport[joystick->index]) == B_ERROR ) {
		SDL_SetError("Unable to open joystick");
		SDL_SYS_JoystickClose(joystick);
		return(-1);
	}

	/* Set the joystick to calibrated mode */
	stick->EnableCalibration();

	/* Get the number of buttons, hats, and axes on the joystick */
	joystick->nbuttons = stick->CountButtons();
	joystick->naxes = stick->CountAxes();
	joystick->nhats = stick->CountHats();

	joystick->hwdata->new_axes = (int16 *)
	                  malloc(joystick->naxes*sizeof(int16));
	joystick->hwdata->new_hats = (uint8 *)
	                  malloc(joystick->nhats*sizeof(uint8));
	if ( ! joystick->hwdata->new_hats || ! joystick->hwdata->new_axes ) {
		SDL_OutOfMemory();
		SDL_SYS_JoystickClose(joystick);
		return(-1);
	}

	/* We're done! */
	return(0);
}

/* Function to update the state of a joystick - called as a device poll.
 * This function shouldn't update the joystick structure directly,
 * but instead should call SDL_PrivateJoystick*() to deliver events
 * and update joystick device state.
 */
void SDL_SYS_JoystickUpdate(SDL_Joystick *joystick)
{
	static const Uint8 hat_map[9] = {
             SDL_HAT_CENTERED,
             SDL_HAT_UP,
             SDL_HAT_RIGHTUP,
             SDL_HAT_RIGHT,
             SDL_HAT_RIGHTDOWN,
             SDL_HAT_DOWN,
             SDL_HAT_LEFTDOWN,
             SDL_HAT_LEFT,
             SDL_HAT_LEFTUP
	};
	const int JITTER = (32768/10);	/* 10% jitter threshold (ok?) */

	BJoystick *stick;
	int i, change;
	int16 *axes;
	uint8 *hats;
	uint32 buttons;

	/* Set up data pointers */
	stick = joystick->hwdata->stick;
	axes = joystick->hwdata->new_axes;
	hats = joystick->hwdata->new_hats;

	/* Get the new joystick state */
	stick->Update();
	stick->GetAxisValues(axes);
	stick->GetHatValues(hats);
	buttons = stick->ButtonValues();

	/* Generate axis motion events */
	for ( i=0; i<joystick->naxes; ++i ) {
		change = ((int32)axes[i] - joystick->axes[i]);
		if ( (change > JITTER) || (change < -JITTER) ) {
			SDL_PrivateJoystickAxis(joystick, i, axes[i]);
		}
	}

	/* Generate hat change events */
	for ( i=0; i<joystick->nhats; ++i ) {
		if ( hats[i] != joystick->hats[i] ) {
			SDL_PrivateJoystickHat(joystick, i, hat_map[hats[i]]);
		}
	}

	/* Generate button events */
	for ( i=0; i<joystick->nbuttons; ++i ) {
		if ( (buttons&0x01) != joystick->buttons[i] ) {
			SDL_PrivateJoystickButton(joystick, i, (buttons&0x01));
		}
		buttons >>= 1;
	}
}

/* Function to close a joystick after use */
void SDL_SYS_JoystickClose(SDL_Joystick *joystick)
{
	if ( joystick->hwdata ) {
		joystick->hwdata->stick->Close();
		delete joystick->hwdata->stick;
		if ( joystick->hwdata->new_hats ) {
			free(joystick->hwdata->new_hats);
		}
		if ( joystick->hwdata->new_axes ) {
			free(joystick->hwdata->new_axes);
		}
		free(joystick->hwdata);
		joystick->hwdata = NULL;
	}
}

/* Function to perform any system-specific joystick related cleanup */
void SDL_SYS_JoystickQuit(void)
{
	int i;

	for ( i=0; SDL_joyport[i]; ++i ) {
		free(SDL_joyport[i]);
	}
	SDL_joyport[0] = NULL;

	for ( i=0; SDL_joyname[i]; ++i ) {
		free(SDL_joyname[i]);
	}
	SDL_joyname[0] = NULL;
}

}; // extern "C"