Mercurial > sdl-ios-xcode
view src/audio/mint/SDL_mintaudio_it.S @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | c83fa1c650dd |
| children | d48ead2d2ba5 ea2a327b92d7 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ /* Audio interrupts Patrice Mandin, Didier Méquignon */ .text .globl _SDL_MintAudio_Callback .globl _SDL_MintAudio_XbiosInterrupt .globl _SDL_MintAudio_XbiosInterruptMeasureClock .globl _SDL_MintAudio_Dma8Interrupt .globl _SDL_MintAudio_StfaInterrupt .globl _SDL_MintAudio_mutex .globl _SDL_MintAudio_audiobuf .globl _SDL_MintAudio_numbuf .globl _SDL_MintAudio_audiosize .globl _SDL_MintAudio_clocktics .globl _SDL_MintAudio_stfa /* How it works: - Audio is playing buffer #0 (resp. #1) - We must calculate a sample in buffer #1 (resp. #0) so we first call the callback to do it - Then we swap the buffers */ #define savptr 0x4a2 #define savamt 0x46 /*--- Xbios interrupt vector to measure Falcon external clock ---*/ _SDL_MintAudio_XbiosInterruptMeasureClock: /* 1 mS */ btst #0,0xFFFF8901:w /* state DMA sound */ beqs SDL_MintAudio_EndIntMeasure addql #1,_SDL_MintAudio_clocktics SDL_MintAudio_EndIntMeasure: bclr #5,0xFFFFFA0F:w /* Clear service bit */ rte /*--- Xbios interrupt vector ---*/ _SDL_MintAudio_XbiosInterrupt: /* Reenable interrupts, so other interrupts can work */ movew #0x2300,sr /* Clear service bit, so other MFP interrupts can work */ bclr #5,0xfffffa0f:w /* Check if we are not already running */ tstw _SDL_MintAudio_mutex bnes SDL_MintAudio_XbiosEnd notw _SDL_MintAudio_mutex /* Swap buffers */ eorw #1,_SDL_MintAudio_numbuf moveml d0-d7/a0-a6,sp@- /* Callback */ jsr _SDL_MintAudio_Callback /* Reserve space for registers */ subl #savamt,savptr /* Set new buffer */ moveq #0,d0 movel _SDL_MintAudio_audiosize,d1 movew _SDL_MintAudio_numbuf,d0 lsll #2,d0 lea _SDL_MintAudio_audiobuf,a0 movel a0@(d0:l),a1 lea a1@(d1:l),a2 movel a2,sp@- movel a1,sp@- clrw sp@- movew #131,sp@- trap #14 lea sp@(12),sp /* Restore registers space */ addl #savamt,savptr moveml sp@+,d0-d7/a0-a6 clrw _SDL_MintAudio_mutex SDL_MintAudio_XbiosEnd: rte /*--- DMA 8 bits interrupt vector ---*/ _SDL_MintAudio_Dma8Interrupt: /* Reenable interrupts, so other interrupts can work */ movew #0x2300,sr /* Clear service bit, so other MFP interrupts can work */ bclr #5,0xfffffa0f:w /* Check if we are not already running */ tstw _SDL_MintAudio_mutex bnes SDL_MintAudio_Dma8End notw _SDL_MintAudio_mutex /* Swap buffers */ eorw #1,_SDL_MintAudio_numbuf moveml d0-d7/a0-a6,sp@- /* Callback */ jsr _SDL_MintAudio_Callback /* Set new buffer */ moveq #0,d0 movew _SDL_MintAudio_numbuf,d0 lslw #2,d0 lea _SDL_MintAudio_audiobuf,a0 movel a0@(d0:w),d1 /* Modify DMA addresses */ lea 0xffff8900:w,a0 moveb d1,a0@(0x07) /* Start address */ rorl #8,d1 moveb d1,a0@(0x05) rorl #8,d1 moveb d1,a0@(0x03) swap d1 addl _SDL_MintAudio_audiosize,d1 moveb d1,a0@(0x13) /* End address */ rorl #8,d1 moveb d1,a0@(0x11) rorl #8,d1 moveb d1,a0@(0x0f) moveml sp@+,d0-d7/a0-a6 clrw _SDL_MintAudio_mutex SDL_MintAudio_Dma8End: rte /*--- STFA interrupt vector ---*/ STFA_SOUND_START = 6 STFA_SOUND_END = STFA_SOUND_START+8 _SDL_MintAudio_StfaInterrupt: /* Reenable interrupts, so other interrupts can work */ movew #0x2300,sr /* Check if we are not already running */ tstw _SDL_MintAudio_mutex bnes SDL_MintAudio_StfaEnd notw _SDL_MintAudio_mutex /* Swap buffers */ eorw #1,_SDL_MintAudio_numbuf moveml d0-d7/a0-a6,sp@- /* Callback */ jsr _SDL_MintAudio_Callback /* Set new buffer */ moveq #0,d0 movel _SDL_MintAudio_stfa,a1 movew _SDL_MintAudio_numbuf,d0 lslw #2,d0 lea _SDL_MintAudio_audiobuf,a0 movel a0@(d0:w),d1 /* Modify STFA replay buffers */ movel d1,a1@(STFA_SOUND_START) addl _SDL_MintAudio_audiosize,d1 movel d1,a1@(STFA_SOUND_END) moveml sp@+,d0-d7/a0-a6 clrw _SDL_MintAudio_mutex SDL_MintAudio_StfaEnd: rte