Mercurial > sdl-ios-xcode
view src/SDL_fatal.c @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Mon, 28 Nov 2005 13:58:26 +0000 |
parents | 51a8702d8ecd |
children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif #ifdef _WIN32_WCE #define NO_SIGNAL_H #endif /* General fatal signal handling code for SDL */ #ifdef NO_SIGNAL_H /* No signals on this platform, nothing to do.. */ void SDL_InstallParachute(void) { return; } void SDL_UninstallParachute(void) { return; } #else #include <stdlib.h> #include <stdio.h> #include <signal.h> #include <string.h> #include "SDL.h" #include "SDL_fatal.h" #ifdef __CYGWIN__ #define DISABLE_STDIO #endif /* This installs some signal handlers for the more common fatal signals, so that if the programmer is lazy, the app doesn't die so horribly if the program crashes. */ static void print_msg(const char *text) { #ifndef DISABLE_STDIO fprintf(stderr, "%s", text); #endif } static void SDL_Parachute(int sig) { signal(sig, SIG_DFL); print_msg("Fatal signal: "); switch (sig) { case SIGSEGV: print_msg("Segmentation Fault"); break; #ifdef SIGBUS #if SIGBUS != SIGSEGV case SIGBUS: print_msg("Bus Error"); break; #endif #endif /* SIGBUS */ #ifdef SIGFPE case SIGFPE: print_msg("Floating Point Exception"); break; #endif /* SIGFPE */ #ifdef SIGQUIT case SIGQUIT: print_msg("Keyboard Quit"); break; #endif /* SIGQUIT */ #ifdef SIGPIPE case SIGPIPE: print_msg("Broken Pipe"); break; #endif /* SIGPIPE */ default: #ifndef DISABLE_STDIO fprintf(stderr, "# %d", sig); #endif break; } print_msg(" (SDL Parachute Deployed)\n"); SDL_Quit(); exit(-sig); } static int SDL_fatal_signals[] = { SIGSEGV, #ifdef SIGBUS SIGBUS, #endif #ifdef SIGFPE SIGFPE, #endif #ifdef SIGQUIT SIGQUIT, #endif 0 }; void SDL_InstallParachute(void) { /* Set a handler for any fatal signal not already handled */ int i; #ifdef HAVE_SIGACTION struct sigaction action; for ( i=0; SDL_fatal_signals[i]; ++i ) { sigaction(SDL_fatal_signals[i], NULL, &action); if ( action.sa_handler == SIG_DFL ) { action.sa_handler = SDL_Parachute; sigaction(SDL_fatal_signals[i], &action, NULL); } } #ifdef SIGALRM /* Set SIGALRM to be ignored -- necessary on Solaris */ sigaction(SIGALRM, NULL, &action); if ( action.sa_handler == SIG_DFL ) { action.sa_handler = SIG_IGN; sigaction(SIGALRM, &action, NULL); } #endif #else void (*ohandler)(int); for ( i=0; SDL_fatal_signals[i]; ++i ) { ohandler = signal(SDL_fatal_signals[i], SDL_Parachute); if ( ohandler != SIG_DFL ) { signal(SDL_fatal_signals[i], ohandler); } } #endif /* HAVE_SIGACTION */ return; } void SDL_UninstallParachute(void) { /* Remove a handler for any fatal signal handled */ int i; #ifdef HAVE_SIGACTION struct sigaction action; for ( i=0; SDL_fatal_signals[i]; ++i ) { sigaction(SDL_fatal_signals[i], NULL, &action); if ( action.sa_handler == SDL_Parachute ) { action.sa_handler = SIG_DFL; sigaction(SDL_fatal_signals[i], &action, NULL); } } #else void (*ohandler)(int); for ( i=0; SDL_fatal_signals[i]; ++i ) { ohandler = signal(SDL_fatal_signals[i], SIG_DFL); if ( ohandler != SDL_Parachute ) { signal(SDL_fatal_signals[i], ohandler); } } #endif /* HAVE_SIGACTION */ } #endif /* NO_SIGNAL_H */