Date: Sat, 10 Apr 2004 02:25:33 -0400 From: Glenn Maynard To: sdl@libsdl.org Subject: [SDL] SDL_SetVideoMode() failing and not setting an error (patch) Running an OpenGL SDL application off 1.2.7, at SDL_InitSubSystem(SDL_INIT_VIDEO) time: Warning: Unable to initialize AAlib mouseUsing AAlib driver: Slang driver 1.0 (slang) SDL_SetVideoMode then fails; SDL_GetError() returns "". The installation problem is straightforward: X (the higher priority driver) isn't running, so SDL is falling back on aalib. However, no error is being set when aalib fails to initialize. This also happens with the svgalib driver. SDL_video.c line ~653 sets mode to NULL, since aalib didn't return an OpenGL surface. Line ~711 ("failed setting a video mode") returns NULL. The attached patch sets an error. It's a horrible, useless error message--it should really say eg. "aalib does not support OpenGL"; this should probably be done earlier in the individual drivers, too.

Makefile.in
Makefile
configure
config.cache
config.log
config.status
autom4te*
aclocal.m4
checkkeys
graywin
loopwave
testalpha
testbitmap
testcdrom
testcpuinfo
testerror
testgamma
testgl
testhread
testjoystick
testkeys
testlock
testoverlay
testoverlay2
testpalette
testsem
testsprite
testtimer
testtypes
testver
testvidinfo
testwin
testwm
threadwin