Mercurial > sdl-ios-xcode
view src/thread/pth/SDL_sysmutex.c @ 997:3bf4103b2b89
Date: Sat, 27 Nov 2004 13:35:43 +0100
From: "Martin Bickel"
Subject: [SDL] Patch: fixing uninitilized palette
while running Valgrind over my application I found the following
problem in SDL:
The function MapNto1 allocates SDL_Color colors[256] but does not
initialize it.
SDL_DitherColors is then called which initialized the r, g and b
component, but not the 'unused' component of each color.
When Map1to1 is called from MapNto1, it runs a memcmp on the colors,
which also evaluates the unused component and therefor returns
differences much more often than necessary.
So the 'unused' component of SDL_Color should be initialized. This
patch does this by calling memset for the whole array in MapNto1 .
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 30 Nov 2004 14:28:20 +0000 |
parents | 1d74ddc90cb2 |
children | 3692456e7b0f |
line wrap: on
line source
/* * GNU pth mutexes * * Patrice Mandin */ #include <stdio.h> #include <stdlib.h> #include <pth.h> #include "SDL_error.h" #include "SDL_mutex.h" #include "SDL_sysmutex_c.h" /* Create a mutex */ SDL_mutex *SDL_CreateMutex(void) { SDL_mutex *mutex; /* Allocate mutex memory */ mutex = (SDL_mutex *)malloc(sizeof(*mutex)); if ( mutex ) { /* Create the mutex, with initial value signaled */ if (!pth_mutex_init(&(mutex->mutexpth_p))) { SDL_SetError("Couldn't create mutex"); free(mutex); mutex = NULL; } } else { SDL_OutOfMemory(); } return(mutex); } /* Free the mutex */ void SDL_DestroyMutex(SDL_mutex *mutex) { if ( mutex ) { free(mutex); } } /* Lock the mutex */ int SDL_mutexP(SDL_mutex *mutex) { if ( mutex == NULL ) { SDL_SetError("Passed a NULL mutex"); return -1; } pth_mutex_acquire(&(mutex->mutexpth_p), FALSE, NULL); return(0); } /* Unlock the mutex */ int SDL_mutexV(SDL_mutex *mutex) { if ( mutex == NULL ) { SDL_SetError("Passed a NULL mutex"); return -1; } pth_mutex_release(&(mutex->mutexpth_p)); return(0); }