Date: Sat, 27 Nov 2004 13:35:43 +0100 From: "Martin Bickel" Subject: [SDL] Patch: fixing uninitilized palette while running Valgrind over my application I found the following problem in SDL: The function MapNto1 allocates SDL_Color colors[256] but does not initialize it. SDL_DitherColors is then called which initialized the r, g and b component, but not the 'unused' component of each color. When Map1to1 is called from MapNto1, it runs a memcmp on the colors, which also evaluates the unused component and therefor returns differences much more often than necessary. So the 'unused' component of SDL_Color should be initialized. This patch does this by calling memset for the whole array in MapNto1 .

#if defined(USE_ASM_MIXER_VC)
// headers for MMX assembler version of SDL_MixAudio
// Copyright 2002 Stephane Marchesin (stephane.marchesin@wanadoo.fr)
// Converted to Intel ASM notation by Cth
// This code is licensed under the LGPL (see COPYING for details)
// 
// Assumes buffer size in bytes is a multiple of 16
// Assumes SDL_MIX_MAXVOLUME = 128

void SDL_MixAudio_MMX_S16_VC(char* ,char* ,unsigned int ,int );
void SDL_MixAudio_MMX_S8_VC(char* ,char* ,unsigned int ,int );
#endif