Mercurial > sdl-ios-xcode
view test/torturethread.c @ 1524:38a12fd1a2c1
Fixed bug #46
Date: Fri, 13 Jan 2006 18:09:45 -0500
From: mhall4400 vipmail kvcc edu
Subject: Possible SDL bug
Greetings
I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM
control portion of the library.
When calling the SDL_CDPlay() function to play the last track of a CD using the
offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the
following error from a call to SDL_Error():
mciSendCommand() error: The specified parameter is out of range for the
specified command.
The code returning the error is:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
g_playingDriveSDLCD->track[trackNumberInt].length)
Subtracting one from the length of the provided length seems to repair the
problem:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
(g_playingDriveSDLCD->track[trackNumberInt].length) - 1)
Ive replicated this problem on Windows 98 SE (several months since last
patch), fully-patched Window ME, seldom-patched Windows XP SP1, and
fully-patched Windows XP SP2.
While investigating the issue, I came across a line in your librarys win32
source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive
from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add
1 to the value for length to fix MCI last track length bug. This may be the
source of the issue (because subtracting 1 from the length seems to resolve the
issue). Microsoft may have patched the referenced bug since you wrote that
line.
Mike Hall
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 14 Mar 2006 05:34:39 +0000 |
parents | 1dd8bf30a109 |
children | d5298e8f22b3 |
line wrap: on
line source
/* Simple test of the SDL threading code */ #include <stdio.h> #include <stdlib.h> #include <signal.h> #include <string.h> #include "SDL.h" #include "SDL_thread.h" #define NUMTHREADS 10 static char volatile time_for_threads_to_die[NUMTHREADS]; /* Call this instead of exit(), so we can clean up SDL: atexit() is evil. */ static void quit(int rc) { SDL_Quit(); exit(rc); } int SubThreadFunc(void *data) { while(! *(int volatile *)data) { ; /*SDL_Delay(10);*/ /* do nothing */ } return 0; } int ThreadFunc(void *data) { SDL_Thread *sub_threads[NUMTHREADS]; int flags[NUMTHREADS]; int i; uintptr_t tid = (uintptr_t)data; fprintf(stderr, "Creating Thread %d\n", tid); for(i = 0; i < NUMTHREADS; i++) { flags[i] = 0; sub_threads[i] = SDL_CreateThread(SubThreadFunc, &flags[i]); } printf("Thread '%d' waiting for signal\n", tid); while(time_for_threads_to_die[tid] != 1) { ; /* do nothing */ } printf("Thread '%d' sending signals to subthreads\n", tid); for(i = 0; i < NUMTHREADS; i++) { flags[i] = 1; SDL_WaitThread(sub_threads[i], NULL); } printf("Thread '%d' exiting!\n", tid); return 0; } int main(int argc, char *argv[]) { SDL_Thread *threads[NUMTHREADS]; uintptr_t i; /* Load the SDL library */ if ( SDL_Init(0) < 0 ) { fprintf(stderr, "Couldn't initialize SDL: %s\n",SDL_GetError()); return(1); } signal(SIGSEGV, SIG_DFL); for(i = 0; i < NUMTHREADS; i++) { time_for_threads_to_die[i] = 0; threads[i] = SDL_CreateThread(ThreadFunc, (void *) i); if ( threads[i] == NULL ) { fprintf(stderr, "Couldn't create thread: %s\n", SDL_GetError()); quit(1); } } for(i = 0; i < NUMTHREADS; i++) { time_for_threads_to_die[i] = 1; } for(i = NUMTHREADS-1; i >= 0; --i) { SDL_WaitThread(threads[i], NULL); } SDL_Quit(); return(0); }