To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Wed, 28 Dec 2005 12:13:20 +0100 Subject: [SDL] Fix for opening documents on Mac OS X < 10.4 The current code in SDLMain.m that transforms documents opened from the Finder into command-line arguments (introduced in revision 1.14, 2005-08-11) uses the methods -[NSString lengthOfBytesUsingEncoding:] and -[NSString getCString:maxLength:encoding:], which are only available in Mac OS X 10.4. Compiling this code on 10.3 produces warnings, and running it (i.e. starting an SDL application by opening a document) leads to weird behavior which I didn't investigate in detail ("*** -[NSCFString lengthOfBytesUsingEncoding:]: selector not recognized" is printed to the console log, and the SDL window never opens). The attached patch removes the offending calls and uses -[NSString UTF8String] instead, which is available everywhere. Tested on 10.3.9, and I see no reason why it shouldn't also work on 10.2 and 10.4. Two further comments: * The comment above the -[SDLMain application: openFile:] implementation says "You need to have a CFBundleDocumentsType section in your Info.plist to get this message, apparently." This is not the case in my experience - it worked just fine with a hand-built bare-bones application consisting only of Test.app/Contents/MacOS/test, without any Info.plist (although you have to press the option and command keys for such an application to accept a dragged file). * I took the liberty of cleaning up another area of SDLMain.m: I changed "CustomApplicationMain (argc, argv)" to "CustomApplicationMain (int argc, char **argv)". This avoids the "type of `argv' defaults to `int'" warnings, and I'm not sure if leaving out the types could cause problems on platforms where an int and a char** aren't of the same size. -Christian

These are test programs for the SDL library:

	testver		Check the version and dynamic loading and endianness
	testtypes	Check to see if the data types are the correct size
	testhread	Hacked up test of multi-threading
	testlock	Hacked up test of multi-threading and locking
	testerror	Tests multi-threaded error handling
	testsem		Tests SDL's semaphore implementation
	testtimer	Test the timer facilities
	loopwave	Audio test -- loop playing a WAV file
	testcdrom	Sample audio CD control program
	testkeys	List the available keyboard keys
	testvidinfo	Show the pixel format of the display and perfom the benchmark
	checkkeys	Watch the key events to check the keyboard
	testwin		Display a BMP image at various depths
	graywin		Display a gray gradient and center mouse on spacebar
	testsprite	Example of fast sprite movement on the screen
	testbitmap	Test displaying 1-bit bitmaps
	testalpha	Display an alpha faded icon -- paint with mouse
	testwm		Test window manager -- title, icon, events
	threadwin	Test multi-threaded event handling
	testgl		A very simple example of using OpenGL with SDL
	testjoystick	List joysticks and watch joystick events
	testoverlay	Tests the software/hardware overlay functionality.
	testoverlay2	Tests the overlay flickering/scaling during playback.
	testblitspeed	Tests performance of SDL's blitters and converters.